From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id D3834385C017 for ; Thu, 19 Mar 2020 12:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D3834385C017 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584619362; bh=AM7esaiTV9waOh/8H92dTzCaabTVMGUw3Cxqfo+BKvg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=dSLr5eao0Rn6peDYrWCm2ZYQcePJsxohcBihCS6vWFs2KHlT1DOMK53PbDX7lodw4 5C8YPu8uH9RlruQnq/7IfA0R/2LFBsxEa4qei/fGyBCviqOt5z0dT9SB0T/vJZZUtB RIXTHQ+Wm7p6d/eSqAN6JMxFipz413zkn/vROnsM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MVvPD-1ipHqW3KsP-00RseF; Thu, 19 Mar 2020 13:02:42 +0100 Subject: Re: [PATCH v3] Disable get_ptrace_pid for NetBSD To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200318215531.25248-1-n54@gmx.com> <20200318231651.18045-1-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <4c4aae3e-2a5d-0050-6ce1-8eaaea037157@gmx.com> Date: Thu, 19 Mar 2020 13:01:24 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0bKnlGoABKrwrM0ThxsrhjfgrVu3DNYen" X-Provags-ID: V03:K1:OKrud3YPI7L9ZxpT9pSkBRe/k5VGxWWgKhVJgE/GXuHlzyimHbo ts1N0TyjdwQ47uBbr9SGUpJhdnoKLCdjKwiO+UCu3F0aeLva1pgzQmwPLrB28BdqHqYzkMB lpo1Ld7kMDrfVAG3C6F940A8wDegta07/ia54+9FuvgrRguH/TVrGquH5o8hq524/DMjI6n OY7V+tJE691JbyzKSMkug== X-UI-Out-Filterresults: notjunk:1;V03:K0:GtX6fWayL5M=:qvHPaMwRFsKCNOxQ3EZDCU FoiIMr9M/JxdCfpZx7d85OrQeMT8TS6M+HYC6zPGnDns+RCFouX/77v7F4VxZUmCVzK/PjA/2 OUf+JuOpI46T5XbZOSN2ZRZ5tY5gU1tNNfu680H18I/ipAY1jL52Ln5JRr1X1jbM1HfBpSmuM lEqttSFEPrzwuyqxoGEG6kLlQlamIG62V/2Cp7Ko56JgePmZNe0T8FfBZPTgrZ48TaD7fJI2i P308SpprR1O71tdVARyxkULwcRDqD0J6o6cF++N6tDb6DYUWikhjkN9+YX4R/PxyamAfWaPRv E+CjEOLezjkbwupkowXq+iei7+WMRVh61e2COl44mQKJbT/SkGhcC8MjDw+ubQyTwfo7kB5ho OX/uCc1obvrlar5abfR840xGf7Wv/O7steNvx+DDXbhtHLzDy00QG0/7Liq1o/0jRjP569JgA 0sP8Ww41TeyjrWxoM5CNBx0Nfn2viz4bU6P8F9XySTjjAPtthL9tcmLdgo0FxW8Gqmn0TGKk6 uoH64TKKRqqunc6dOF/Acqg9R80RjGRJXfiym8jDdmZKlGEjbFt33nmd87SPOmLJMKrwP5WeA ldKHhI9yystlzQGlDKao6spBGXAsi/ivh4iiLYY7kDSkujIypPyKDXivuBB3IoeWvEYaslNgr TdlEMn/shldzzAi8m8YEcmJAfvmKjc8idMbNlz3SlnKIIJ21VikjNiXmEVR7j0LMadj44aFz/ CnRUPXzEBplH/cIGqKtR9OTmhsVZiWj1+BEs4telFytoawy+hpHURdKBBiSfbBC72HFz9qDsj TK6V88ajSccoivseA5DBOEkVMmmRQZtLVJMNBEcqPInebwm/HHZMgQhTwFjrOjJSTu2plbO0Y 3JyFkrN5EoNTN3HdXtqlznUwhXmnbABC4YpG0sDmH/T4SO+jksYXIim3ho0kBQmnm3HKGFyF7 sTC0yrd8B+QOeCKOSp+X9BLaOVSf0xHDuz3oLRBfeAtAtHSWH/xbhkHl3XVW4BbN0+Znn+Fhk 6F6FCzIhHcSbhFEokLXBogTMy65JzszMW6TIhi/ZUbALJtQ2102tSDp4mMI5PFGtTXmExVVTE EVQD3QcZp4aSFYdblYKm6Lk7E1bz5MfSSp6rCqjePWHGfJF7O7eFmRugIrEOMwlVN3HyBomsM WDKU/Cnc+LE+41B2UDaDf1lY80lZt6HGEVbSvL+iNPIO+beiXnAqqCtl3Opm8CnHmZ5hk= X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 12:03:00 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0bKnlGoABKrwrM0ThxsrhjfgrVu3DNYen Content-Type: multipart/mixed; boundary="AHErHRnzfmBqE2wQn81PQg71pxrLK0yIA"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com Message-ID: <4c4aae3e-2a5d-0050-6ce1-8eaaea037157@gmx.com> Subject: Re: [PATCH v3] Disable get_ptrace_pid for NetBSD References: <20200318215531.25248-1-n54@gmx.com> <20200318231651.18045-1-n54@gmx.com> In-Reply-To: --AHErHRnzfmBqE2wQn81PQg71pxrLK0yIA Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 19.03.2020 02:13, Simon Marchi wrote: > On 2020-03-18 7:16 p.m., Kamil Rytarowski wrote: >> @@ -336,15 +350,14 @@ get_ptrace_pid (ptid_t ptid) >> void >> inf_ptrace_target::resume (ptid_t ptid, int step, enum gdb_signal sig= nal) >> { >> - pid_t pid; >> int request; >> >> if (minus_one_ptid =3D=3D ptid) >> /* Resume all threads. Traditionally ptrace() only supports >> single-threaded processes, so simply resume the inferior. */ >> - pid =3D inferior_ptid.pid (); >> + ptid =3D inferior_ptid; >> else >> - pid =3D get_ptrace_pid (ptid); >> + ptid =3D ptid_t (inferior_ptid.pid ()); >=20 > That's not what I meant. To keep the existing behavior, I believe it s= hould be: >=20 > if (minus_one_ptid =3D=3D ptid) > /* Resume all threads. Traditionally ptrace() only supports > single-threaded processes, so simply resume the inferior. */ > ptid =3D ptid_t (inferior_ptid.pid ()); >=20 OK. >> >> if (catch_syscall_enabled () > 0) >> request =3D PT_SYSCALL; >> @@ -365,7 +378,7 @@ inf_ptrace_target::resume (ptid_t ptid, int step, = enum gdb_signal signal) >> where it was. If GDB wanted it to start some other way, we have= >> already written a new program counter value to the child. */ >> errno =3D 0; >> - ptrace (request, pid, (PTRACE_TYPE_ARG3)1, gdb_signal_to_host (sign= al)); >> + gdb_ptrace (request, ptid, (PTRACE_TYPE_ARG3)1, gdb_signal_to_host = (signal)); >> if (errno !=3D 0) >> perror_with_name (("ptrace")); >> } >=20 > I'm getting this: >=20 > /home/simark/src/binutils-gdb/gdb/inf-ptrace.c: In member function =E2=80= =98virtual void inf_ptrace_target::resume(ptid_t, int, gdb_signal)=E2=80=99= : > /home/simark/src/binutils-gdb/gdb/inf-ptrace.c:379:15: error: invalid c= onversion from =E2=80=98int=E2=80=99 to =E2=80=98__ptrace_request=E2=80=99= [-fpermissive] > 379 | gdb_ptrace (request, ptid, (PTRACE_TYPE_ARG3)1, gdb_signal_to= _host (signal)); > | ^~~~~~~ > | | > | int > /home/simark/src/binutils-gdb/gdb/inf-ptrace.c:41:30: note: initializ= ing argument 1 of =E2=80=98int gdb_ptrace(__ptrace_request, ptid_t, long = int, long int)=E2=80=99 > 41 | gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_= ARG3 addr, >=20 >=20 > We would need to change the type of the variable `ret` to PTRACE_TYPE_A= RG1. >=20 > I'll make a test run on Linux with those changes to check if there's an= y regression. >=20 I presume you mean variable `request', not `ret'. Done. > Simon >=20 --AHErHRnzfmBqE2wQn81PQg71pxrLK0yIA-- --0bKnlGoABKrwrM0ThxsrhjfgrVu3DNYen Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5zXyAACgkQS7MI6bAu dmwPtw//bMWI7gH1NJJTl5vtGHYHKcQJWqrFJ9wnCsj96g8Otz9BFvibbvkOG3Ti kgYuzqR84gWZ84QnadZNjc9SaM4AA1J7Bj7IaQV2kVswtgrd1KCAqQxQSU5v7eIN xC0IK8pM/OfQgxnU3IKtSUpZuFThV1f2LKksn9Ueyzn4+bufEY10uDzgLsS093EY yM96sAKwONjat2T+Rtbme3Y18q6LA/gl6uPMgWxE4xmmnAEiXbo1TpkBMtBcSndB YlB448Km105hNXpzR+pN7RsSca8qWzkttCy2CYYoZzPSG4kMqv80oEAB3tur1k5u NOUlWBI3OYGjfmDtWhV2NgM7cw6aAX/ug3h1wzuQW9AMKBq/86+CQ5PwL4pwZyYr s9X1AHTq4BbaTMfxQ/JUKEce03vkQSe0RlhejfMRz0sJKAeB0YTo9sEDnNuffaJq eMEE4P0eVs05KfSIedmWWiRuPeH1GZElNCmtWzxSSaB2Gdot2SUpGOEBYljHzswu yxKkA1HaYlwPau1uKf9q0gEglXP0z2IwS8LCEgA6XtmS3nDeGU+V6s/Gd0b8vUIx +uKXGiz/KNZePHTHc+433XAbZC2zBnkxw9Q1VIH/QsiwJOAccFDU8Y0GbdcqD0vj RBiGTaZTXZtjAnHSCbIietfP7Vb/MX8s4rNnwrJnTCknV+itMp8= =wjPX -----END PGP SIGNATURE----- --0bKnlGoABKrwrM0ThxsrhjfgrVu3DNYen--