From: Pedro Alves <palves@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4][PR gdb/19893] Fix handling of synthetic C++ references
Date: Tue, 31 May 2016 19:09:00 -0000 [thread overview]
Message-ID: <4c1bda84-e98d-6d06-7eed-410bb4b98d00@redhat.com> (raw)
In-Reply-To: <CAOKbPbbixq_BkLH3pEU5uDySBNM8NhDzkOu_ksiHgBdU5UAYzg@mail.gmail.com>
On 05/31/2016 08:01 PM, Martin Galvan wrote:
> I also noticed Bugzilla detected that I commited something related to
> the bug and automatically sent an e-mail reporting it. That's pretty
> cool, how does it work so I can always make it happen? Does it scan
> the commit message for the PR number?
Correct.
It's also standard procedure to put the PR number in the ChangeLog [1],
which I totally forgot to point out in review. Could you add
it (both gdb/ and gdb/testsuite/ ChangeLogs) now, please? No need to
post that patch, just go ahead and push it.
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-31 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 18:35 Martin Galvan
2016-05-31 18:42 ` Pedro Alves
2016-05-31 19:02 ` Martin Galvan
2016-05-31 19:09 ` Pedro Alves [this message]
2016-05-31 19:11 ` Martin Galvan
2016-05-31 19:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1bda84-e98d-6d06-7eed-410bb4b98d00@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=martin.galvan@tallertechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox