Re: [PATCH][gdb/testsuite] Detect gdb prompt after monitor exit

[Pedro Alves <pedro@palves.net>]

On 9/14/20 8:21 PM, Tom de Vries wrote:

> After issuing a "monitor exit" command, we should always get a prompt back, so
> check for that.
> 
> Tested on x86_64-linux.
> 
> Any comments?
> 

Good find.
> @@ -463,6 +465,15 @@ proc gdbserver_exit { is_mi } {
>                     warning "Timed out waiting for EOF in server after $monitor_exit"
>                 }
>  	    }
> +	    if { ! read_prompt } {
> +		expect {
> +		    -i "$gdb_spawn_id" -re "$gdb_prompt $" {
> +		    }
> +		    timeout {
> +			warning "Timed out waiting for prompt after $monitor_exit"
> +		    }
> +		}
> +	    }

So if we get the prompt first, we go back to waiting for the eof.
But if the eof is first, we currently don't continue waiting for
the prompt.  Do we really need this new block of code instead
of just putting:

    if {!$read_prompt} {
      exp_continue
    }

in the eof case?

Thanks,
Pedro Alves