Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32

LRN
2012-09-10T18:32:10Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10.09.2012 22:15, Tom Tromey wrote:
>>>>>> "LRN" == LRN <lrn1986@gmail.com> writes:
>
> LRN> diff --git a/gdb/infcmd.c b/gdb/infcmd.c [...]
>
> LRN> +#if W32_JITDBG LRN> +void LRN> +signal_event_command (char
> *args, int from_tty) LRN> +{
>
> Two notes here.
>
> First, does it make sense to put this in windows-nat.c instead? (I
> don't know anything about the Windows port...) It doesn't matter
> hugely.
Probably. I'll try to move it there and see how it goes.

> Second, it is odd to call this a _command and give it the above
> prototype. Normally this convention is used for things which are
> really commands -- visible to the user from the gdb CLI.
>
> I suppose this is so you can use catch_command_errors; but it seems
> like you could equally well use catch_errors.
I mostly copied the code around it. Since this is something related to
attaching, i started with attach command. Probably not the best
choice, since it's not what i thought it was :)

> LRN> + struct cleanup *back_to = make_cleanup (null_cleanup,
> NULL);
>
> You don't need a null cleanup unless you plan to make other
> cleanups. But AFAICT there aren't any.
I thought that null cleanup is to be able to call error()

> LRN> + dont_repeat (); /* Not for the faint of heart */
>
> You only need this for a real command.
>
OK.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQTjIQAAoJEOs4Jb6SI2CwoN4IAKMCSafAb2SzzIzon/J38rpn
1naD4umbbBstbzMVUqesU8NmrdRWqlOjuWbpsXd8anruKvfMk2jFZpftzqIWXzZb
df8E5wBFLMH8JECWDGU8DUGJA/bBOmfswa2R9aGTgvaWya/fLcPzXmij3DQWy5sW
kXxa9IQidKe30v6XE40lUbwd6ThWGjBLDW/N3CGOmQyOmmWMCV97f1o1A/k/CmM7
x4MI3YJ4u16GVIaLTiiegAnhAu2AjupbV+7TI97bLWvRMAhI2f+KyM8XX5hceTul
qToORY6T/aS1Gij/RSDKSPzA19BqVLAH80BS1d0n3gqKptRt4wXRDE157tAZugY=
=YWbM
-----END PGP SIGNATURE-----