Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32

LRN
2012-10-01T16:22:18Z

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01.10.2012 17:18, Eli Zaretskii wrote:
>> Date: Sun, 30 Sep 2012 16:46:30 +0400 From: LRN
>> <lrn1986@gmail.com>
>>
>> Attached the patch.
>
> Thanks. Final 2 comments:
>
> . you patch has 2 stray ^M characters, please remove them when
> committing
Ran dos2unix on it. Should be fine now.

> . you still have at least one place with 1 space between sentences
ARGH! Yeah, fixed.

P.S. I'm not committing it. Last 2 or 3 patch modifications were made
by editing the patch file directly, i didn't go through
git-commit-format-patch routine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQacMtAAoJEOs4Jb6SI2CwOS8IAJkAhFysaExHJok1cCZ7xP30
dD8YA8QwtrhIIt/CK1y9JA34AEw9DTw9AWASsSeAvIBsaDi8AVxaqhCpqqU5AzZs
fvdxW1kYyKdSzKJmzqvw26Ip1pbjCNNBxdpevnQHTvHArE0Ylcy++hDKQ0TbP4l1
8tBP70aqXEHuN4ynp+sSA0S++fU4hpnkA/yUzd57DcIs2tMqQfAEIWiejsTGaPLX
7IhNIseabyoOGVePDie7aYoApjQuyV7dytzo4WlGuPgH5uLo7oGzFk2cePbvjiGs
Gk5iLUO/UfUykkG6ChQK9D4WsMMLKcZ4DhCDeYOOqdaxGa7TS50V8cFhWNrdkaA=
=xKbA
-----END PGP SIGNATURE-----

[-- Attachment #2: 0001-Make-gdb-JIT-capable-W32-v6.mingw32.patch --]
[-- Type: text/plain, Size: 3964 bytes --]

From 68db59b52726d0838b5974ec201becfebed8f27d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD=20=D0=98=D0=B6=D0=B1=D1?=
=?UTF-8?q?=83=D0=BB=D0=B0=D1=82=D0=BE=D0=B2?= <lrn1986@gmail.com>
Date: Sat, 29 Sep 2012 18:16:16 +0400
Subject: [PATCH] Make gdb JIT-capable (MS-Windows)

Adds the signal-event command (MS-Windows-only) that signals
an event with user-provided ID. Used to resume crashing
process when attached to it via MS-Windows JIT debugging (AeDebug).

PR gdb/14529
---
gdb/doc/gdb.texinfo | 26 ++++++++++++++++++++++++++
gdb/windows-nat.c | 22 ++++++++++++++++++++++
2 files changed, 49 insertions(+)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 5fcbada..555563a 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -18859,6 +18859,33 @@ This is a Cygwin-specific alias of @code{info shared}.
This command loads symbols from a dll similarly to
add-sym command but without the need to specify a base address.

+@kindex signal-event
+@item signal-event @var{id}
+This command signals an event with user-provided @var{id}. Used to resume
+crashing process when attached to it using MS-Windows JIT debugging (AeDebug).
+
+To use it, create or edit the following keys in
+@code{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug} and/or
+@code{HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\AeDebug}
+(for x86_64 versions):
+
+@itemize @minus
+@item
+@code{Debugger} (REG_SZ) --- a command to launch the debugger. Suggested
+command is: @code{@var{fully-qualified-path-to-gdb.exe} -ex "attach %ld"
+-ex "signal-event %ld" -ex "continue"}
+
+First @code{%ld} will be replaced by process ID, second @code{%ld} will be
+replaced by ID of the event that blocks the crashing process, waiting for
+debugger to attach.
+
+@item
+@code{Auto} (REG_SZ) --- either @code{1} or @code{0}. @code{1} will make the
+system run debugger specified by Debugger key automatically, @code{0} will
+cause a dialog box with ``OK'' and ``Cancel'' buttons to appear, which allows
+the user to either terminate crashing process (OK) or debug it (Cancel).
+@end itemize
+
@kindex set cygwin-exceptions
@cindex debugging the Cygwin DLL
@cindex Cygwin DLL, debugging
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 905d4bf..f003ece 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -933,6 +933,25 @@ dll_symbol_command (char *args, int from_tty)
safe_symbol_file_add (args, from_tty, NULL, 0, OBJF_SHARED | OBJF_USERLOADED);
}

+static void
+signal_event_command (char *args, int from_tty)
+{
+ uintptr_t event_id = 0;
+ char *endargs = NULL;
+
+ if (args == NULL)
+ error (_("signal-event requires an argument (integer event id)"));
+
+ event_id = strtoumax (args, &endargs, 10);
+
+ if ((errno == ERANGE) || (event_id == 0) || (event_id > UINTPTR_MAX) ||
+ ((HANDLE) event_id == INVALID_HANDLE_VALUE))
+ error (_("Failed to convert `%s' to event id"), args);
+
+ SetEvent ((HANDLE) event_id);
+ CloseHandle ((HANDLE) event_id);
+}
+
/* Handle DEBUG_STRING output from child process.
Cygwin prepends its messages with a "cygwin:". Interpret this as
a Cygwin signal. Otherwise just print the string as a warning. */
@@ -2547,6 +2566,13 @@ _initialize_windows_nat (void)
cygwin_internal (CW_SET_DOS_FILE_WARNING, 0);
#endif

+ c = add_com ("signal-event", class_run, signal_event_command, _("\
+Signal a crashed process with event ID, to allow its debugging.\n\
+This command is needed in support of setting up GDB as JIT debugger on \
+MS-Windows. The command should be invoked from the GDB command line using \
+the '-ex' command-line option. The ID of the event that blocks the \
+crashed process will be supplied by the Windows JIT debugging mechanism."));
+
c = add_com ("dll-symbols", class_files, dll_symbol_command,
_("Load dll library symbols from FILE."));
set_cmd_completer (c, filename_completer);
--
1.7.11