From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94468 invoked by alias); 28 Jun 2017 19:00:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94209 invoked by uid 89); 28 Jun 2017 19:00:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 spammy=sheer, luck X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 19:00:45 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AEE77D0C5; Wed, 28 Jun 2017 19:00:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5AEE77D0C5 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5AEE77D0C5 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 878DD7ABE8; Wed, 28 Jun 2017 19:00:42 +0000 (UTC) Subject: Re: [PATCH 23/25] [GDBserver] Convert amd64-linux target descriptions To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-24-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <4bd302d0-326c-307a-5f9e-07f3b97131dd@redhat.com> Date: Wed, 28 Jun 2017 19:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-24-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00771.txt.bz2 On 06/12/2017 09:41 AM, Yao Qi wrote: > +static const struct target_desc *amd64_tdescs[X86_TDESC_LAST] = { }; > +static const struct target_desc *x32_tdescs[X86_TDESC_LAST] = { }; > + > + > + if (is_x32) > + tdesc = (struct target_desc **) &x32_tdescs[idx]; > + else > + tdesc = (struct target_desc **) &amd64_tdescs[idx]; > + > + if (*tdesc == NULL) > + { > + *tdesc = new target_desc (); You can't cast away constness of really-const objects and write to them. The compiler is free to place the array in read-only storage. If this doesn't crash at run time, it's sheer luck. Thanks, Pedro Alves