From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by sourceware.org (Postfix) with ESMTPS id 069E33857032 for ; Wed, 22 Jul 2020 18:56:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 069E33857032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f65.google.com with SMTP id f18so2981389wml.3 for ; Wed, 22 Jul 2020 11:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iT2e9qyY5OaV35LS4I73NEl4TeMH4NQR8pjIJNaXIVo=; b=r2h8Pa0cqfUg/uMJU8dCw2j7Rb/0uXTMJDEFJd4kXn95IhmeVwuR9utf7Jt2nLA+Xg kSYUkXGUle/CiUvvKQFxfZf4USA6zFgd6wjD3hZ8ityEluqa5vtr33L+60VnFfpDXgVH MivBsSFMWFv1JSs9FZ365F5FER9jOSbI11GrIQq/DkMW0fcSTANk1LRmHZd+tpS7NUyp 3wk407y2kCoTkE00ua46E+2oBtTSz96qOfZZx6v0sAOqXHzmoxunYpUMhfV56vwl4I/I Curuo9Q0A/JJF8T4B2Pp/gDgoDhz9Ki405PR+X6Lq5QU0hESj99n3jBgHijEMmblu0xb cMhA== X-Gm-Message-State: AOAM530zmb2ScJjIZqdcbn2Fqf1hfHDH9ziGUNrsi9uUfN1fnBAg6KXN WKCzkH0h16GXARbCKZ3LtW3HwPqVpXA= X-Google-Smtp-Source: ABdhPJx9M81Q3ahjJW0GuJp3aPnlAwU3J3nFppBwERXHzSq8jR9/GgunjKmopqLQ4YoLP6mTPk7USA== X-Received: by 2002:a05:600c:210:: with SMTP id 16mr360368wmi.165.1595444211488; Wed, 22 Jul 2020 11:56:51 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x204sm5210719wmg.2.2020.07.22.11.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 11:56:50 -0700 (PDT) Subject: Re: [PATCH v5 11/14] Adjust coredump-filter.exp to account for NT_FILE note handling To: Kevin Buettner , gdb-patches@sourceware.org References: <20200722005832.863276-1-kevinb@redhat.com> <20200722005832.863276-12-kevinb@redhat.com> From: Pedro Alves Message-ID: <4bcd25ee-5212-ea36-63c5-ad147e0165e3@palves.net> Date: Wed, 22 Jul 2020 19:56:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200722005832.863276-12-kevinb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 18:56:54 -0000 On 7/22/20 1:58 AM, Kevin Buettner via Gdb-patches wrote: > + set hide_binfile [standard_output_file "${testfile}.hide"] > + if { $should_fail == 1 } { > + file rename -force $binfile $hide_binfile Shouldn't this be instead: remote_exec host "mv -f $binfile $hide_binfile" so that it works on remote host configurations? > + } > + > set core_loaded [gdb_core_cmd "$core" "load core"] > if { $core_loaded == -1 } { > fail "loading $core" > @@ -96,6 +107,7 @@ proc test_disasm { core address should_fail } { > } > > if { $should_fail == 1 } { > + file rename -force $hide_binfile $binfile Ditto. Otherwise LGTM. Pedro Alves