From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38428 invoked by alias); 17 Apr 2019 22:30:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38417 invoked by uid 89); 17 Apr 2019 22:30:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Swirski, leszek, swirski, Leszek X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Apr 2019 22:30:47 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4E91BAE7F; Wed, 17 Apr 2019 22:30:45 +0000 (UTC) Subject: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation To: Tom Tromey , Leszek Swirski via gdb-patches Cc: Leszek Swirski , palves@redhat.com References: <20190214151602.147300-1-leszeks@google.com> <20190214151810.149322-1-leszeks@google.com> <87v9zducov.fsf@tromey.com> From: Tom de Vries Message-ID: <4bbf8dae-f071-d611-17e6-78f61dffbd27@suse.de> Date: Wed, 17 Apr 2019 22:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <87v9zducov.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00303.txt.bz2 On 16-04-19 18:39, Tom Tromey wrote: >>>>>> ">" == Leszek Swirski via gdb-patches writes: > >>> This ABI mismatch resulted in issues when calling a function that returns >>> a class of size <16 bytes which has a base class, including issues such >>> as the "this" pointer being incorrect (as it was passed as the second >>> argument rather than the first). > > I'm still looking into the problem, but this regressed an internal test > case here at AdaCore. For me, this commit regresses like this: ... FAIL: gdb.base/call-ar-st.exp: print print_small_structs (timeout) FAIL: gdb.base/call-ar-st.exp: print print_small_structs from print_long_arg_list (timeout) FAIL: gdb.base/call-ar-st.exp: print print_bit_flags_combo(*bit_flags_combo) (timeout) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_char(*cflags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_char(*cflags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_short(*sflags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_short(*sflags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags(*flags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags(*flags) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_combo(*flags_combo) FAIL: gdb.base/call-rt-st.exp: print print_bit_flags_combo(*flags_combo) ... Filed as PR24463 - "call-ar-st.exp/call-rt-st.exp regressions". Thanks, - Tom