Re: [PATCH 0/4] Require GNU make

Simon Marchi
2016-11-17T17:05:45Z

On 2016-11-16 11:08, Simon Marchi wrote:
> Following the discussions in
>
> https://sourceware.org/ml/gdb-patches/2016-11/msg00326.html
>
> I am sending this patch series which makes GNU make mandatory for
> building GDB
> and GDBserver.
>
> - Patch 1 simply updates the NEWS file
> - Patch 2 removes code that is conditional on make being GNU make or
> not.
> - Patches 3 and 4 make use of pattern rules, a GNU make-specific
> feature.
>
> Patches 3 and 4 replace patches 1 and 2 in the original series.
>
> Simon Marchi (4):
> Document new hard requirement on GNU make
> Remove code that checks for GNU/non-GNU make
> Makefile: Replace old suffix rules with pattern rules
> Makefile: Replace explicit subdir rules with pattern rules
>
> gdb/Makefile.in | 835
> +++++----------------------------------------
> gdb/NEWS | 5 +
> gdb/configure | 97 ------
> gdb/configure.ac | 11 -
> gdb/gdbserver/Makefile.in | 36 +-
> gdb/gdbserver/configure | 97 ------
> gdb/gdbserver/configure.ac | 11 -
> gdb/testsuite/Makefile.in | 88 +++--
> gdb/testsuite/configure | 99 ------
> gdb/testsuite/configure.ac | 11 -
> 10 files changed, 141 insertions(+), 1149 deletions(-)

Thanks everybody for the reviews and comments, I have now pushed this
series.

I'll follow-up with:

- See if binutils can require GNU make as well, and perhaps have a
check in the top-level makefile
- Disable default implicit rules with .SUFFIXES.

Simon