Re: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules

Simon Marchi
2016-11-17T16:52:07Z

On 2016-11-16 14:10, Pedro Alves wrote:
> IMO, whether to explicitly remove default suffixes from the
> the implicit rule suffixes list for efficiency is a separate
> subject, since we're not currently doing it either.
>
> Just to be sure none of the default suffix rules is necessary,
> can you confirm:
>
> 1. that "make -r" (from scratch) still works.

"make -r" from scratch from the top-level fails in the readline
directory:

ar: readline.o: No such file or directory

It seems like readline relies on implicit rules. It shouldn't be
affected by gdb disabling them though. I did a "make" in the readline
directory to make it build, then resume the top-level build with "make
-r", and it finished cleanly.

> 2. that "make -r diststuff" in the gdb build dir still works.

The commands completes successfully, so it looks good. Still, perhaps
Joel should be a little bit more careful when doing the next release to
make sure nothing it missing.

> If the above work, then this is OK with me to push in.

Just to be clear, this patchset does not disable the default suffix
rules, so I don't think it was really necessary to check that for this
patch. But at least we know it's safe for when we'll want to disable
them.

Thanks,

Simon