Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make

Simon Marchi
2016-11-16T17:12:33Z

On 2016-11-16 11:39, Andreas Schwab wrote:
> On Nov 16 2016, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Since GDB is built by first running Make in sibling directories, which
>> don't require a GNU Make yet, what does this mean in case the user
>> runs a non-GNU Make? Will they have strange errors half way through
>> the build? Should we detect this early on and bail out?
>
> The toplevel makefile already has such a check, only enabled for gcc
> for
> now.

Ah, great. In the discussion [1] linked by Pedro in the order thread,
no one seemed to have an objection about switching binutils-gdb to
require GNU make. So we can probably just make that check
unconditional.

Note that it's not a check for GNU make per-se, but a check for the
.VARIABLES. It's equivalent if GNU make is the only one to provide the
.VARIABLES variable, but I don't know if that's the case.

27 @if gcc
28 ifeq (,$(.VARIABLES)) # The variable .VARIABLES, new with 3.80, is
never empty.
29 $(error GNU make version 3.80 or newer is required.)
30 endif
31 @endif gcc

[1] https://sourceware.org/ml/binutils/2014-05/msg00263.html