From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5861 invoked by alias); 16 Nov 2016 20:18:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5840 invoked by uid 89); 16 Nov 2016 20:18:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:1304 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 20:18:18 +0000 Received: by simark.ca (Postfix, from userid 33) id 7773F1E7FD; Wed, 16 Nov 2016 15:18:16 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Nov 2016 20:18:00 -0000 From: Simon Marchi Cc: Eli Zaretskii , Simon Marchi , gdb-patches@sourceware.org In-Reply-To: References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-4-simon.marchi@ericsson.com> <83lgwjfknq.fsf@gnu.org> <0fa3954e-1f8a-f7f8-aad7-d31d45aa981e@redhat.com> <535c5f310c42d9b4e349f5072068fb2a@polymtl.ca> Message-ID: <4b9404f645d947404d45c3b6aa9a6800@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00459.txt.bz2 On 2016-11-16 14:58, Pedro Alves wrote: > On 11/16/2016 07:38 PM, Simon Marchi wrote: > >> I did some experiments, here's the time it takes to run make in the >> gdb/ >> directory with nothing to re-build. The other number is the number of >> lines printed when running make -d. It gives a rough idea of the >> amount >> of operations make does. >> >> Note that these results are by changing both gdb/Makefile.in and >> gdb/gdbserver/Makefile.in. That's fair, since the -r applies >> recursively as well. >> >> Baseline: 2.5 seconds, 2306335 lines >> With .SUFFIXES: 0.7 seconds, 307706 lines >> With .SUFFIXES and the other %:: rules: 0.6 seconds, 255386 lines >> With -r flag (make -r): 0.5 seconds, 160682 lines > > That's a nice speedup. Presumably if you change gdb/doc/ and > gdb/testsuite/ too, the number without -r gets even closer to > the -r number. Right, but not by much I think. The implicit rules are mostly for yacc, lex and c files. There isn't much target matching those in testsuite and doc. > If it works, I think it'll be nice to put the > ".SUFFIXES and the other %:: rules" bits in a shared makefile fragment > that > is included (with the include directive) by all the main Makefile.in > files. Good idea.