From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155446-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 99672 invoked by alias); 18 Apr 2019 17:08:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 99659 invoked by uid 89); 18 Apr 2019 17:08:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:418
X-HELO: mail-wr1-f49.google.com
Received: from mail-wr1-f49.google.com (HELO mail-wr1-f49.google.com) (209.85.221.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 17:08:20 +0000
Received: by mail-wr1-f49.google.com with SMTP id k17so3814403wrx.10        for <gdb-patches@sourceware.org>; Thu, 18 Apr 2019 10:08:20 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b])        by smtp.gmail.com with ESMTPSA id a8sm2814611wmf.33.2019.04.18.10.08.18        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Thu, 18 Apr 2019 10:08:18 -0700 (PDT)
Subject: Re: [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <cover.1555455013.git.andrew.burgess@embecosm.com> <5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <4b7f0e8d-f9e6-1f30-fe7c-195575bfb682@redhat.com>
Date: Thu, 18 Apr 2019 17:08:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-04/txt/msg00351.txt.bz2

Excellent.  I have no further comments on this version, except for ...

On 4/17/19 12:06 AM, Andrew Burgess wrote:

> +/* See valprint.h.  */
> +
> +bool val_print_check_max_depth (struct ui_file *stream, int recurse,
> +				const struct value_print_options *options,
> +				const struct language_defn *language)


... line break after the bool.

Thanks,
Pedro Alves