From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by sourceware.org (Postfix) with ESMTPS id 527DB3857C47 for ; Mon, 17 Aug 2020 14:00:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 527DB3857C47 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f67.google.com with SMTP id a5so15112509wrm.6 for ; Mon, 17 Aug 2020 07:00:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ii/G+uVC87IVwEm6OCCNItaYqlEv5ut/+2tyeMgqiM8=; b=l4ooQzOI9MjwPABInQtBoOmnhyeQDBvQql28S7kDCWbSHMIgctTXKmAOSDTME/4UmY 8VT9sfT6FT5g50i0ApgzHWOV0SDRgRBBCQkQQsk1SvjecDhti6ZGRHKKWmmDIBQJsQe2 C54c8wajeSNR41VFRQeH0F+6JdRKTx6p3IbS+gjMAKyFoUWqpAEeS/HcuIJzAJonHHxr /0erixcxA6syec3i16VJ8F9kQJW5WhPu+KYo325HYaCBw/zYFbA1TWRNrGEeRevm3DHv nN3htCPJCqyscipnGkXYgQGyuJv4W4bzXYtNKPfA4MAS2NamW3pTeift4PLOuW0aExzf qAaQ== X-Gm-Message-State: AOAM532zo4keXHIra/c3hb98pDOl6wK/nJ2ZaP1cI7nQLfH/8r6qyHY2 up/irOtYoJEjxL6zZtfvajQvxGjmmxpq+w== X-Google-Smtp-Source: ABdhPJxbcWjtzUegaEMDOFJf2SBUM+Wr/rfllb7uDXm2aEv4BQj/GLL+KwVH5/bn7AVdieFHyjlFBw== X-Received: by 2002:adf:d849:: with SMTP id k9mr16520928wrl.115.1597672805686; Mon, 17 Aug 2020 07:00:05 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:56ee:75ff:fe8d:232b? ([2001:8a0:f905:5600:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id 62sm32576031wrq.31.2020.08.17.07.00.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2020 07:00:03 -0700 (PDT) Subject: Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang To: Gary Benson , gdb-patches@sourceware.org References: <1597670664-14171-1-git-send-email-gbenson@redhat.com> From: Pedro Alves Message-ID: <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> Date: Mon, 17 Aug 2020 15:00:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1597670664-14171-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 14:00:08 -0000 On 8/17/20 2:24 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 7/27/20 2:09 PM, Gary Benson via Gdb-patches wrote: >>> Furthermore, gdb.cp/ambiguous.exp has been disabled when using GCC >>> since 1998. >> >> Curious you reference the year, do you know it because you found the >> commit that disabled it? > > Yes :) What it was, then? Does it say anything about why the testcase was disabled? > >>> -if { [test_compiler_info gcc-*] } then { continue } >>> +# GCCs prior to 10.1 do not support -Wno-inaccessible-base. >>> +if { [test_compiler_info {gcc-[0-9]-*}] >>> + || [test_compiler_info {gcc-10-0-*}] } { >> >> Given the first release of GCC 10 is 10.1... > > Ah, I didn't know that. > >> ...do we really need the second check? > > No :) I've removed it. > >>> + unsupported "compiler does not support -Wno-inaccessible-base" >> >> How about instead of bailing out, use "-Wno-inaccessible-base" >> with GCC >= 10, and use "-w" with older GCCs? > > Sure. How about this? OK. Thanks, Pedro Alves