From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40283 invoked by alias); 22 Mar 2018 13:51:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40264 invoked by uid 89); 22 Mar 2018 13:51:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 13:51:33 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9044FEB6FF; Thu, 22 Mar 2018 13:51:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D8272023230; Thu, 22 Mar 2018 13:51:30 +0000 (UTC) Subject: Re: [PATCH 1/2] gdb: Minor cleanup in some gdb.arch/* tests To: Andrew Burgess , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <4b5623c7-72b0-4640-ce94-35be198b718d@redhat.com> Date: Thu, 22 Mar 2018 13:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00422.txt.bz2 On 03/22/2018 12:57 PM, Andrew Burgess wrote: > A small number of tests incorrectly tried to pass -Wa,-g through to > GCC as an extra compile time flag, either to gdb_compile or > prepare_for_testing. > > There were two mistakes, first, the 'debug' flag was already being > passed, this will cause GCC to add a suitable -g flag, which should > then be propagated to the assembler. Secondly, in order to pass > additional compiler flags, the syntax would be > 'additional_flags=-Wa,-g'. As it was, the flag was just being > ignored. > > Given that all these tests pass 'debug', and the invalid flag has been > ignored for some time, I'm just removing the flags in this commit. > > There should be no change in the test results after this commit. OK. > - > if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ > - [list debug $additional_flags]] } { > + [list debug]] } { > return -1 Note you could make these {debug} instead now. "[list ...]" was only necessary because of variable expansion. (Don't know whether that shortens the lines enough to avoid wrapping). Actually, "debug" is the default, so you could just remove them completely: proc prepare_for_testing { testname executable {sources ""} {options {debug}}} { Thanks, Pedro Alves