From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52225 invoked by alias); 1 Jul 2019 19:24:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52106 invoked by uid 89); 1 Jul 2019 19:24:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 19:24:38 +0000 Received: by mail-wm1-f65.google.com with SMTP id s3so634007wms.2 for ; Mon, 01 Jul 2019 12:24:38 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a3sm641189wmb.35.2019.07.01.12.24.35 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 12:24:35 -0700 (PDT) Subject: [users/palves/format_strings] Down with .ptr() (Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)) To: Tom Tromey References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <4e543ef2-eec3-b82c-a84a-a107e1ef2bc2@redhat.com> <5df7a829-1cff-3df4-f2d3-92076cdc4699@redhat.com> <87imslpsxm.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4b29a649-e8de-92fa-2d43-87c61f0fbabb@redhat.com> Date: Mon, 01 Jul 2019 19:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87imslpsxm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00027.txt.bz2 On 7/1/19 6:26 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> static inline styled_string_s * > Pedro> styled_string (const ui_file_style &style, const char *str, > Pedro> styled_string_s &&tmp = {}) > > Nice trick -- I hadn't seen that one before! > > Pedro> Here's a patch implementing the idea above. I wrote this a couple > Pedro> weeks ago, and at the time I felt more strongly about it. Is this > Pedro> worth it? > > Yes, I think so. It removes some clutter. The expense is that the call > is tricky and can't be relied on outside of an argument list, really; > but on the other hand I don't expect these things to be used elsewhere. Yeah, if we ever need to instantiate one of these outside an argument list, we can still instantiate a styled_string_s instead of calling styled_string. But I also don't expect this to be ever necessary. Alright, I merged this one to users/palves/format_strings. Thanks, Pedro Alves