From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id D83003861030
 for <gdb-patches@sourceware.org>; Thu,  6 Aug 2020 14:41:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D83003861030
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 80F1A1E599;
 Thu,  6 Aug 2020 10:41:59 -0400 (EDT)
Subject: Re: [PATCH v3 2/7] amd64_analyze_prologue: swap upper bound check
 condition operands
To: Victor Collod <vcollod@nvidia.com>, gdb-patches@sourceware.org
References: <0cc93067-1313-6434-4330-61a21736376f@simark.ca>
 <20200624012857.31849-1-vcollod@nvidia.com>
 <20200624012857.31849-3-vcollod@nvidia.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <4b19ec90-e2a3-132f-981d-5c9c4e8ad65c@simark.ca>
Date: Thu, 6 Aug 2020 10:41:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200624012857.31849-3-vcollod@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2020 14:42:00 -0000

On 2020-06-23 9:28 p.m., Victor Collod via Gdb-patches wrote:
> `if (current_pc <= pc)' felt backwards, as current_pc doesn't change,
> and the test could be described as "stop if pc went past current_pc".

This LGTM.

Simon