From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Makefiles: Disable suffix rules and implicit rules
Date: Wed, 30 Nov 2016 20:45:00 -0000 [thread overview]
Message-ID: <4b135dbc-4980-90b6-ffb2-dbca002409c9@redhat.com> (raw)
In-Reply-To: <a3cc60f2d1921dde0de5b89e03043f3f@polymtl.ca>
On 11/30/2016 08:29 PM, Simon Marchi wrote:
> On 2016-11-30 06:51, Pedro Alves wrote:
>> On 11/26/2016 04:04 AM, Simon Marchi wrote:
>>
>>>
>>> gdb/ChangeLog:
>>>
>>> * disable-implicit-rules.mk: New file.
>>
>> Please add a copyright header.
>
> Done locally.
>
>>> * Makefile.in: Include disable-implicit-rules.mk.
>>> * data-directory/Makefile.in: Likewise.
>>> * doc/Makefile.in: Likewise.
>>
>> doc/ has its own ChangeLog file.
>
> Whoops. Fixed locally.
>
>> What about gnulib/Makefile.in ?
>
> I thought it was an imported file, but no. It doesn't do much so I
> don't think it will change anything, but I'll add the include in it as
> well, for completeness. Ok with you?
Yes.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-11-30 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 4:04 Simon Marchi
2016-11-30 11:51 ` Pedro Alves
2016-11-30 20:29 ` Simon Marchi
2016-11-30 20:45 ` Pedro Alves [this message]
2016-11-30 21:25 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b135dbc-4980-90b6-ffb2-dbca002409c9@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox