From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4boqA+YNvmiFgzIAWB0awg (envelope-from ) for ; Sun, 07 Sep 2025 18:57:42 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=CmMFTX1l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 097D61E0B8; Sun, 07 Sep 2025 18:57:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 15C3F1E0B8 for ; Sun, 07 Sep 2025 18:57:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC6733858D38 for ; Sun, 7 Sep 2025 22:57:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC6733858D38 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=CmMFTX1l Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id A504F3858D26 for ; Sun, 7 Sep 2025 22:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A504F3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A504F3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285811; cv=none; b=V1CkAL9wSM3rle5SPnTojeTJCYQjUimWClUVf//C6ja0Pn2I1bcWaR78a0JER6rr+L/imwdaxMr7mRBYbMpW0MlucoHa4BFlNBatBgvxSFI8jGcl5d0MiF2T3w4fP6uChYV/jKh2l1iZ0RhRZQW7y0C5+pXwrlRCIgqN7Npiurw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285811; c=relaxed/simple; bh=SKJugIZJdQtD8PQu9oIzWJm9wArn3VqW7dJMYJ9M65o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=c6ov98tPuvpxDC8+8RkOVnWQLjrf+xUHZbUlKBFOYW5bR2bv2YQWWDeHxAhBmUhLpEit53CDyAGPGmTplDM1EMYXSjyUoUroHicQK5zW/KtrzeMBCIg2uKJBHWAg7DO2rf5pKg/Lt0GU+gDLAUxp9cmE99Cze5R+1z+cdb98UQo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A504F3858D26 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-45de64f89a9so2478505e9.1 for ; Sun, 07 Sep 2025 15:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757285809; x=1757890609; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=GGTiH/haVbHCgvQXv4lDAT8zw57unKSTQpAntvYcCCg=; b=CmMFTX1lRojrIgP4k35WYFt8mb6BQJ8OJqX8nPWOOSaJfd0ksYL9JVC9TFn1hsnzyO 2TF+NV3x/udiY4Z/vETI+zYGeRep81KEwUUyTYl3zHme+KIlTOo3MqBTa8Pv8HCSMLV4 dMPdaS/lE5V+SoY8UvVCqzXBwC3lzrnEVbTZp0b3bXM17BGrB9A9l3shBpE8osTbyUid AEcvvH86WOwdSHsSOeCX+1RNwQymQEz+VM86iwRQVnM6LqaO83xvHwalxpfyE1O9mkdh sXblMYAdeO5llikOF1ODrHs1ICHwQb7035OMN+cioIWQdeGQqYCY/GNHwlrAGxvXGEq5 ep/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757285809; x=1757890609; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GGTiH/haVbHCgvQXv4lDAT8zw57unKSTQpAntvYcCCg=; b=jzNn0en7JB/Q0rxZLJyqToXc7tJUAKhq/C3T8kPOh04WivaF4eCAe9SphOcnzVEOFl pGLFrvZAJS4QXTpOdxoeHADlmV6pNu5OvIA3cUrzbkmUm7ZkGbGfJtoC1gAGO26FCoPa PqVhHOYQgR68O2Tgu0J5ERLUU/F/VqBxqVJphRNv1PEd5IxaVbLqJvgecqCqeiXIcDPE f51wf94RcFG7llU4LG/Mq3Y5OlPCWuZg/PfXcuXVbbvp+HHn411lkanzNjqGoXph/c3u tzb3C7Ve42J6mUOV4eEBrHUqZBh6+vR/kbfpcQxVCOIh0Og2+hYIE4zvHtYunBGEDd1i 58Sw== X-Forwarded-Encrypted: i=1; AJvYcCX8vXw4jTGYE9+BjuC5Mnw/6r5xCz7xhyuFGvJNlb66gcIygFAPJcJrVbHnXPtNnesJz/05bRB26gebYw==@sourceware.org X-Gm-Message-State: AOJu0YzsIUFKTHng4fu0+nWL1jxJZq7oppDdvjeSCnIBtaxiHm1//T9t b/kCUJrF6gSUfGWKsQxkaJ9LhrU03bb31FSWvz6jb2WNX5qFsgBDXPih+cFV2Ij5 X-Gm-Gg: ASbGncsD2sNAt8Fj19e1nRBQ4dOTW5Vwzrf2KWDQ6rKHbWfj2wJ1quZiqhDldECToZf qzdKlmfpNte+hazINFLZmtYDGcDc1MUSZVDRwEk2ple9JLN1GZZFgvaMAg/f2FOXDR9bIDWuZcc Xwx4JBIZ+aw8YaT2JmEEF67tI3SSWNN3rVFNUDPlFM0O087k+CXZdf1n0Q7OeTsBalxdXQBQzp3 x+/9EUVNvs4oIsoVgiz7lm1Sv/QH8d+1MzUmJ3mYushRa67Xz2jPQe9n3iookcQcq5WFBNYnIav EFMANtNgof8i+Q5yPmNWHCEsTY8IBxGSuLua0rzW38jl0aRiYsdkirtoAxf0Hwmfc7pUHZx1oaH j+ybFD5d2fMmsp4w11hCbYKOikIoRzEXPx5BgDXgSSSM2+g== X-Google-Smtp-Source: AGHT+IFfQd1ov5TInqrwKla0Dmwv7Zyf7uUhk30qkdgn1sd629gnDCMgmAOQ7GIxRmkXI5YjYLQIEA== X-Received: by 2002:a05:6000:1a87:b0:3da:484a:30db with SMTP id ffacd0b85a97d-3e3051b8317mr6920005f8f.22.1757285808976; Sun, 07 Sep 2025 15:56:48 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45dcfcacd2csm80721475e9.1.2025.09.07.15.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Sep 2025 15:56:48 -0700 (PDT) Message-ID: <4b10117d-094a-40ee-b3d9-6eecbfaf2808@gmail.com> Date: Sun, 7 Sep 2025 23:56:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Luis Subject: Re: [RFC PATCH 5/5] gdb/aarch64: Tests for fpmr To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org References: <20250905131707.77027-1-Ezra.Sitorus@arm.com> <20250905131707.77027-6-Ezra.Sitorus@arm.com> Content-Language: en-US In-Reply-To: <20250905131707.77027-6-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks for the patch. On 05/09/2025 14:17, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add tests for FPMR support in gdb/gdbserver. These tests check > availability of FPMR, reading/writing to FPMR and core file generation. > > For these tests, I have used shrinkwrap for FPMR emulation. I am not > sure on how to do these tests properly as there are some things I'm not > sure about: > > * Which board file do I use to test this? I've resorted to adapting > remote-stdio-gdbserver.exp to use tcp when starting gdbserver > remotely. If you have Linux running on the FVP, you need to build gdb/gdbserver natively in there or cross-build aarch64-linux versions of gdb/gdbserver , copy the binaries over and then invoke the testsuite like so: make check-gdb RUNTESTFLAGS="--target_board=native-gdbserver" You'll run gdb's testsuite against gdbserver inside the FVP. It will be fairly slow for sure, but that's unfortunately how it goes. If you want to exercise gdbserver in extended-remote mode, replace native-gdbserver with native-extended-gdbserver. > * Do I need to run the whole regression test? This is quite slow, and > comes up with a lot of failures. It is a good idea to run the entire testsuite at least once to make sure things didn't break somewhere. If your change is aarch64-specific, it still makes sense to run the entire testsuite (maybe run it on a big server to see if things are still sane), but once you know the code is OK, you can then focus on the gdb.arch/*aarch64*.exp tests. > * Since gdbserver doesn't support core files, I've had to adapt > core_find so that the core file is generated on target (where > gdbserver runs), but then it's copied over to host (where gdb runs) to > do the actual test. You can find this on aarch64-fpmr-core.exp > (remote_core_find). Please let me know if there's a better way of > doing this, or how I can improve the way I've done it. You don´t need to have those changes. > * Another issue with the core file test is that sometimes it says all > the tests pass, but there's 1 unexpected core file or that core files > can't be generated and I need to do ulimit -c unlimited, despite > having done that already. You need to check 2 things, the ulimit -c and the core file pattern in /proc/sys/kernel/core_pattern. I usually use core.%p, and that seems to make the testsuite happy. > --- > gdb/testsuite/gdb.arch/aarch64-fpmr-core.c | 109 +++++++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp | 143 ++++++++++++++++++ > .../gdb.arch/aarch64-fpmr-sighandler.c | 134 ++++++++++++++++ > .../gdb.arch/aarch64-fpmr-sighandler.exp | 75 +++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr.c | 117 ++++++++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr.exp | 116 ++++++++++++++ > gdb/testsuite/lib/gdb.exp | 49 ++++++ > 7 files changed, 743 insertions(+) > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.exp > > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr-core.c b/gdb/testsuite/gdb.arch/aarch64-fpmr-core.c > new file mode 100644 > index 00000000000..95c6f302ad7 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr-core.c > @@ -0,0 +1,109 @@ > +/* This file is part of GDB, the GNU debugger. > + > + Copyright 2008-2025 Free Software Foundation, Inc. If this is new, use only 2025. If you've based the code on another source file, then you should use the range. Same comment for all the other files. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > + > +uint64_t crash_address = 0; > + > +enum FPM_FORMAT > +{ > + E5M2, > + E4M3, > +}; > + > +enum FPM_OVERFLOW > +{ > + INFNAN, > + SATURATE, > +}; > + > +void > +set_fpmr (uint64_t value) > +{ > + register uint64_t x0_val asm ("x0") = value; > + __asm__ volatile (".inst 0xd51b4440" : : ); > +} > + > +uint64_t > +modify_src1_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~(0x7)) | (fmt & 0x7); > +} > + > +uint64_t > +modify_src2_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 3)) | ((fmt & 0x7) << 3); > +} > + > +uint64_t > +modify_dst_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 6)) | ((fmt & 0x7) << 6); > +} > + > +uint64_t > +modify_osm (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 14)) | ((overflow & 0x1) << 14); > +} > + > +uint64_t > +modify_osc (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 15)) | ((overflow & 0x1) << 15); > +} > + > +uint64_t > +modify_lscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0x7f) << 16)) | ((scale & 0x7f) << 16); > +} > + > +uint64_t > +modify_nscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0xff) << 24)) | ((scale & 0xff) << 24); > +} > + > +uint64_t > +modify_lscale2 (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((uint64_t)(0x3f) << 32)) | ((uint64_t)(scale & 0x3f) << 32); > +} > + > +int > +main (void) > +{ > + uint64_t fpmr = 0; > + /* CHECK SRC1 0 */ > + > + fpmr = modify_src1_fmt (fpmr, E4M3); > + fpmr = modify_src2_fmt (fpmr, E4M3); > + fpmr = modify_dst_fmt (fpmr, E4M3); > + fpmr = modify_osm (fpmr, SATURATE); > + fpmr = modify_osc (fpmr, SATURATE); > + fpmr = modify_lscale (fpmr, -1); > + fpmr = modify_nscale (fpmr, -1); > + fpmr = modify_lscale2 (fpmr, -1); > + set_fpmr (fpmr); > + /* Check FPMR */ > + > + *((uint64_t *) crash_address) = 0xDEAD; /* crash point */ > + > + return 1; > +} > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp b/gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp > new file mode 100644 > index 00000000000..52acfd7291b > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp See gdb.arch/aarch64-mte-core.exp for an example on how to test core/gcore file generation. > @@ -0,0 +1,143 @@ > +# Copyright (C) 2018-2025 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This file is part of the gdb testsuite. > + > +# Test generating and reading a core file with FPMR. > + > +proc check_fpmr_core_file { core_filename } { > + # Load the core file. > + if [gdb_test "core $core_filename" \ > + [multi_line \ > + "Core was generated by .*" \ > + "Program terminated with signal SIGSEGV, Segmentation fault\\." \ > + "#0 ${::hex} in main \\(.*\\) at .*" \ > + ".* \\*\\(\\(uint64_t \\*\\) crash_address\\) = 0xDEAD.*"] \ > + "load core file"] { > + untested "failed to generate core file" > + return -1 > + } > + > + # Check the value of FPMR in the core file. > + gdb_test "print/x \$fpmr" " = 0x3fff7fc049" \ > + "fpmr contents from core file" > +} > + > +proc remote_core_find {binfile {deletefiles {}} {arg ""}} { > + global objdir subdir REMOTE_TMPDIR > + > + set target_binfile [gdbserver_download_current_prog] > + > + set destcore "$target_binfile.core" > + remote_exec target delete $destcore > + > + set found 0 > + set coredir "${REMOTE_TMPDIR}/coredir.[getpid]" > + remote_exec target "mkdir $coredir" > + remote_exec target "(cd ${coredir}; ulimit -c unlimited; ${target_binfile} ${arg}; true) >/dev/null 2>&1" > + set binfile_basename [file tail $target_binfile] > + foreach i [list \ > + ${coredir}/core \ > + ${coredir}/core.coremaker.c \ > + ${coredir}/${binfile_basename}.core \ > + ${coredir}/${binfile_basename}.exe.core] { > + if [remote_file target exists $i] { > + remote_exec target "mv $i $destcore" > + set found 1 > + } > + } > + > + if { $found == 0 } { > + set names [glob -nocomplain -directory $coredir core.*] > + if {[llength $names] == 1} { > + set corefile [file join $coredir [lindex $names 0]] > + remote_exec target "mv $corefile $destcore" > + set found 1 > + } > + } > + > + foreach deletefile $deletefiles { > + remote_file target delete [file join $coredir $deletefile] > + } > + remote_exec target "rmdir $coredir" > + > + if { $found == 0 } { > + warning "can't generate a core file - core tests suppressed - check ulimit -c" > + return "" > + } > + set native_corefile "${binfile}.core" > + remote_download host [remote_upload target $destcore] $native_corefile > + > + return $native_corefile > +} > + > +require is_aarch64_target > +require allow_aarch64_fpmr_tests > + > +standard_testfile > +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { > + return -1 > +} > + > +set binfile [standard_output_file ${testfile}] > + > +if ![runto_main] { > + untested "could not run to main" > + return -1 > +} > + > +set crash_breakpoint "crash point" > +gdb_breakpoint [gdb_get_line_number $crash_breakpoint] > +gdb_continue_to_breakpoint $crash_breakpoint > + > +gdb_test "print/x \$fpmr" " = 0x3fff7fc049" \ > + "fpmr contents from core file" > + > +gdb_test "continue" \ > +[multi_line \ > + "Program received signal SIGSEGV, Segmentation fault\\." \ > + "${::hex} in main \\(\\).* at .*" \ > + ".* \\*\\(\\(uint64_t \\*\\) crash_address\\) = 0xDEAD.*"] \ > + "run to crash" > + > +# Generate the gcore core file. > +set gcore_filename [standard_output_file "${testfile}.gcore"] > +set gcore_generated [gdb_gcore_cmd "$gcore_filename" "generate gcore file"] > + > +# Generate a native core file. > +set core_filename [remote_core_find ${binfile}] > +set core_generated [expr {$core_filename != ""}] > + > +# At this point we have a couple core files, the gcore one generated by GDB > +# and the native one generated by the Linux Kernel. Make sure GDB can read > +# both correctly. > + > +if {$gcore_generated} { > + clean_restart ${binfile} > + with_test_prefix "gcore corefile" { > + check_fpmr_core_file $gcore_filename > + } > +} else { > + fail "gcore corefile not generated" > +} > + > +if {$core_generated} { > + clean_restart ${binfile} > + with_test_prefix "native corefile" { > + check_fpmr_core_file $core_filename > + } > +} else { > + untested "native corefile not generated" > +} > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c b/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c > new file mode 100644 > index 00000000000..4ca68a38072 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c > @@ -0,0 +1,134 @@ > +/* This file is part of GDB, the GNU debugger. > + > + Copyright 2008-2025 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > +#include > +#include > +#include > + > +enum FPM_FORMAT > +{ > + E5M2, > + E4M3, > +}; > + > +enum FPM_OVERFLOW > +{ > + INFNAN, > + SATURATE, > +}; > + > +void > +set_fpmr (uint64_t value) > +{ > + register uint64_t x0_val asm ("x0") = value; > + __asm__ volatile (".inst 0xd51b4440" : : ); > +} > + > +uint64_t > +modify_src1_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~(0x7)) | (fmt & 0x7); > +} > + > +uint64_t > +modify_src2_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 3)) | ((fmt & 0x7) << 3); > +} > + > +uint64_t > +modify_dst_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 6)) | ((fmt & 0x7) << 6); > +} > + > +uint64_t > +modify_osm (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 14)) | ((overflow & 0x1) << 14); > +} > + > +uint64_t > +modify_osc (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 15)) | ((overflow & 0x1) << 15); > +} > + > +uint64_t > +modify_lscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0x7f) << 16)) | ((scale & 0x7f) << 16); > +} > + > +uint64_t > +modify_nscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0xff) << 24)) | ((scale & 0xff) << 24); > +} > + > +uint64_t > +modify_lscale2 (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((uint64_t)(0x3f) << 32)) | ((uint64_t)(scale & 0x3f) << 32); > +} > + > +void > +handler (int sig) > +{ > + uint64_t fpmr = 0; > + fpmr = modify_src1_fmt (fpmr, E4M3); > + fpmr = modify_src2_fmt (fpmr, E5M2); > + fpmr = modify_dst_fmt (fpmr, E4M3); > + fpmr = modify_osm (fpmr, INFNAN); > + fpmr = modify_osc (fpmr, SATURATE); > + fpmr = modify_lscale (fpmr, 0); > + fpmr = modify_nscale (fpmr, -1); > + fpmr = modify_lscale2 (fpmr, 0); > + set_fpmr (fpmr); > + > + exit(0); > +} > + > +int > +main () > +{ > + /* Ensure all the signals aren't blocked. */ > + sigset_t newset; > + sigemptyset (&newset); > + sigprocmask (SIG_SETMASK, &newset, NULL); > + > + signal (SIGILL, handler); > + > + uint64_t fpmr = 0; > + > + fpmr = modify_src1_fmt (fpmr, E5M2); > + fpmr = modify_src2_fmt (fpmr, E4M3); > + fpmr = modify_dst_fmt (fpmr, E5M2); > + fpmr = modify_osm (fpmr, SATURATE); > + fpmr = modify_osc (fpmr, INFNAN); > + fpmr = modify_lscale (fpmr, -1); > + fpmr = modify_nscale (fpmr, 0); > + fpmr = modify_lscale2 (fpmr, -1); > + set_fpmr (fpmr); > + > + /* 0x06000000 : Cause an illegal instruction. Value undefined as per ARM > + Architecture Reference Manual ARMv8, Section C4.1. */ > + __asm __volatile (".inst 0x06000000"); > + > + return 0; > +} > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp b/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp > new file mode 100644 > index 00000000000..2ba9818b42c > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp > @@ -0,0 +1,75 @@ > +# Copyright 2018-2025 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > +# > +# This file is part of the gdb testsuite. Add a comment explaining what the test exercises. > + > +require is_aarch64_target > +require allow_aarch64_fpmr_tests > + > +standard_testfile > +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { > + return -1 > +} > + > +if ![runto_main] { > + return -1 > +} > + > +set reg_main_value "0x3f007f4008" > +set reg_handler_value "0xff008041" > + > +proc check_fpmr {value} { > + gdb_test "print /x \$fpmr" \ > + ".* = {?$value}?" \ > + "check register \$fpmr has value $value" > +} > + > +# Run until end of signal handler > + > +gdb_test "continue" \ > + "Continuing.*Program received signal SIGILL.*" \ > + "continue until signal" > + > +gdb_breakpoint [gdb_get_line_number "exit(0)"] > +gdb_continue_to_breakpoint "exit" ".*exit.*" > + > +set handlerframe [get_current_frame_number] > +set mainframe [expr $handlerframe + 2] > + > +# Check register values > + > +with_test_prefix "handler frame 1st" { > + check_fpmr $reg_handler_value > +} > + > +# Switch to the frame for main(), and check register values > + > +gdb_test "frame $mainframe" \ > + "#$mainframe.*main ().*" \ > + "set to main frame" > + > +with_test_prefix "main frame" { > + check_fpmr $reg_main_value > +} > + > +# Switch back to the signal handler frame, and check register values > + > +gdb_test "frame $handlerframe" \ > + "#$handlerframe.*handler \\\(sig=4\\\).*" \ > + "set to signal handler frame" > + > +with_test_prefix "handler frame 2nd" { > + check_fpmr $reg_handler_value > +} > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr.c b/gdb/testsuite/gdb.arch/aarch64-fpmr.c > new file mode 100644 > index 00000000000..f4bf889c3a8 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr.c > @@ -0,0 +1,117 @@ > +/* This file is part of GDB, the GNU debugger. > + > + Copyright 2008-2025 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > + > +enum FPM_FORMAT > +{ > + E5M2, > + E4M3, > +}; > + > +enum FPM_OVERFLOW > +{ > + INFNAN, > + SATURATE, > +}; > + > +void > +set_fpmr (uint64_t value) > +{ > + register uint64_t x0_val asm ("x0") = value; > + __asm__ volatile (".inst 0xd51b4440" : : ); > +} > + > +uint64_t > +modify_src1_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~(0x7)) | (fmt & 0x7); > +} > + > +uint64_t > +modify_src2_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 3)) | ((fmt & 0x7) << 3); > +} > + > +uint64_t > +modify_dst_fmt (uint64_t fpmr, uint64_t fmt) > +{ > + return (fpmr & ~((0x7) << 6)) | ((fmt & 0x7) << 6); > +} > + > +uint64_t > +modify_osm (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 14)) | ((overflow & 0x1) << 14); > +} > + > +uint64_t > +modify_osc (uint64_t fpmr, uint64_t overflow) > +{ > + return (fpmr & ~((0x1) << 15)) | ((overflow & 0x1) << 15); > +} > + > +uint64_t > +modify_lscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0x7f) << 16)) | ((scale & 0x7f) << 16); > +} > + > +uint64_t > +modify_nscale (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((0xff) << 24)) | ((scale & 0xff) << 24); > +} > + > +uint64_t > +modify_lscale2 (uint64_t fpmr, uint64_t scale) > +{ > + return (fpmr & ~((uint64_t)(0x3f) << 32)) | ((uint64_t)(scale & 0x3f) << 32); > +} > + > +int > +main (void) > +{ > + uint64_t fpmr = 0; > + > + fpmr = modify_src1_fmt (fpmr, E4M3); > + set_fpmr (fpmr); /* MODIFY SRC1 */ > + > + fpmr = modify_src2_fmt (fpmr, E4M3); > + set_fpmr (fpmr); /* MODIFY SRC2 */ > + > + fpmr = modify_dst_fmt (fpmr, E4M3); > + set_fpmr (fpmr); /* MODIFY DST */ > + > + fpmr = modify_osm (fpmr, SATURATE); > + set_fpmr (fpmr); /* MODIFY OSM */ > + > + fpmr = modify_osc (fpmr, SATURATE); > + set_fpmr (fpmr); /* MODIFY OSC */ > + > + fpmr = modify_lscale (fpmr, -1); > + set_fpmr (fpmr); /* MODIFY LSCALE */ > + > + fpmr = modify_nscale (fpmr, -1); > + set_fpmr (fpmr); /* MODIFY NSCALE */ > + > + fpmr = modify_lscale2 (fpmr, -1); > + set_fpmr (fpmr); /* MODIFY LSCALE2 */ > + > + return 1; > +} > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr.exp b/gdb/testsuite/gdb.arch/aarch64-fpmr.exp > new file mode 100644 > index 00000000000..211f6fdd40a > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr.exp > @@ -0,0 +1,116 @@ > +# Copyright 2023-2025 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . */ > + > +# Exercise reading/writing FPMR when there is FPMR. Am I missing something or is gdb.arch/aarch64-fpmr.exp only exercising gdb reading the registers written by the testcase and not attempting to write to fpmr? > + > +require is_aarch64_target > +require allow_aarch64_fpmr_tests > + > +standard_testfile > +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { > + return -1 > +} > + > +if ![runto_main] { > + untested "could not run to main" > + return -1 > +} > + > +gdb_test_multiple "info register \$fpmr" "Test FPMR SRC1 E5M2" { > + -re ".*\r\n.*\[ F8S1=E5M2 F8S2=E5M2 F8D=E5M2 OSM=Inf OSC=Inf/NaN LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR SRC1 matches E5M2" > + } > +} > + > +set modify_src1_bp "MODIFY SRC1" > +gdb_breakpoint [gdb_get_line_number $modify_src1_bp] > +gdb_continue_to_breakpoint $modify_src1_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E5M2 F8D=E5M2 OSM=Inf OSC=Inf/NaN LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR SRC1 matches E4M3, SRC2 matches E5M2" > + } > +} > + > +set modify_src2_bp "MODIFY SRC2" > +gdb_breakpoint [gdb_get_line_number $modify_src2_bp] > +gdb_continue_to_breakpoint $modify_src2_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E5M2 OSM=Inf OSC=Inf/NaN LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR SRC2 matches E4M3" > + } > +} > + > +set modify_dst_bp "MODIFY DST" > +gdb_breakpoint [gdb_get_line_number $modify_dst_bp] > +gdb_continue_to_breakpoint $modify_dst_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=Inf OSC=Inf/NaN LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR DST matches E4M3" > + } > +} > + > +set modify_osm_bp "MODIFY OSM" > +gdb_breakpoint [gdb_get_line_number $modify_osm_bp] > +gdb_continue_to_breakpoint $modify_osm_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=MaxNormal OSC=Inf/NaN LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR OSM matches MaxNormal" > + } > +} > + > +set modify_osc_bp "MODIFY OSC" > +gdb_breakpoint [gdb_get_line_number $modify_osc_bp] > +gdb_continue_to_breakpoint $modify_osc_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=MaxNormal OSC=MaxNormal LSCALE=0 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR OSC matches MaxNormal" > + } > +} > + > +set modify_lscale_bp "MODIFY LSCALE" > +gdb_breakpoint [gdb_get_line_number $modify_lscale_bp] > +gdb_continue_to_breakpoint $modify_lscale_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=MaxNormal OSC=MaxNormal LSCALE=127 NSCALE=0 LSCALE2=0 \]" { > + pass "FPMR LSCALE matches" > + } > +} > + > +set modify_nscale_bp "MODIFY NSCALE" > +gdb_breakpoint [gdb_get_line_number $modify_nscale_bp] > +gdb_continue_to_breakpoint $modify_nscale_bp > + > +# GDB does not present bitfields as signed value. > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=MaxNormal OSC=MaxNormal LSCALE=127 NSCALE=255 LSCALE2=0 \]" { > + pass "FPMR NSCALE matches" > + } > +} > + > +set modify_lscale2_bp "MODIFY LSCALE2" > +gdb_breakpoint [gdb_get_line_number $modify_lscale2_bp] > +gdb_continue_to_breakpoint $modify_lscale2_bp > + > +gdb_test_multiple "info register \$fpmr" "" { > + -re ".*\r\n.*\[ F8S1=E4M3 F8S2=E4M3 F8D=E4M3 OSM=MaxNormal OSC=MaxNormal LSCALE=127 NSCALE=255 LSCALE2=63 \]" { > + pass "FPMR LSCALE2 matches" > + } > +} I think there is a better way to write these checks. Instead of duplicating most of the checks, we can build a list of breakpoints and a list of expected output values for each breakpoint. And you also have control over the breakpoint names, so you could index them with a counter. Then you can refactor these checks into a loop (using foreach) that goes through the breakpoints and checks the values. > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index ab4506a4455..a6961fb8719 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5266,6 +5266,55 @@ proc aarch64_supports_sme_svl { length } { > return 1 > } > > +# Run a test on the target to see if it supports AArch64 FPMR hardware. s/AArch64 FPMR hardware/AArch64's FPMR > +# Return 1 if so, 0 if it does not. Note this causes a restart of GDB. > + > +gdb_caching_proc allow_aarch64_fpmr_tests {} { > + global srcdir subdir gdb_prompt inferior_exited_re > + > + set me "allow_aarch64_fpmr_tests" > + > + if { ![is_aarch64_target]} { > + return 0 > + } > + > + set compile_flags "{additional_flags=-march=armv8-a}" See allow_aarch64_sme_tests for how we try to compile an instruction related to the feature and only when we fail we switch to raw hex instruction. > + > + # Compile a test program that writes to FPMR. > + set src { > + int main() { > + asm volatile (".inst 0xd51b4440"); > + return 0;> + } > + } > + if {![gdb_simple_compile $me $src executable $compile_flags]} { > + return 0 > + } > + > + # Compilation succeeded so now run it via gdb. > + clean_restart $obj > + gdb_run_cmd > + gdb_expect { > + -re ".*Illegal instruction.*${gdb_prompt} $" { > + verbose -log "\n$me fpmr not detected" s/fpmr/fpmr support > + set allow_fpmr_tests 0 > + } > + -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { > + verbose -log "\n$me: fpmr hardware detected" s/fpmr hardware/fpmr support > + set allow_fpmr_tests 1 > + } > + default { > + warning "\n$me: default case taken" > + set allow_fpmr_tests 0 > + } > + } > + gdb_exit > + remote_file build delete $obj > + > + verbose "$me: returning $allow_fpmr_tests" 2 > + return $allow_fpmr_tests > +} > + > # Run a test on the target to see if it supports AArch64 MOPS (Memory > # Operations) extensions. Return 1 if so, 0 if it does not. Note this > # causes a restart of GDB. A more general comment on the test source files. They appear to be mostly duplicated. For instance, does the core file test need to have all of the functions that modify fpmr, or is it enough if you modify it once and then check the core file contents? The same goes for the signal handler test