From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87159 invoked by alias); 11 Sep 2017 19:16:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86863 invoked by uid 89); 11 Sep 2017 19:16:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Sep 2017 19:16:50 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8BJGh1H001458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Sep 2017 15:16:47 -0400 Received: by simark.ca (Postfix, from userid 112) id 072471ECB9; Mon, 11 Sep 2017 15:16:43 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 97BB11EA19; Mon, 11 Sep 2017 15:16:42 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Sep 2017 19:16:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Rename _const functions to use overloading instead In-Reply-To: <20170911003325.3765-2-tom@tromey.com> References: <20170911003325.3765-1-tom@tromey.com> <20170911003325.3765-2-tom@tromey.com> Message-ID: <4b0162170770e53193e90e681161aff7@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 11 Sep 2017 19:16:43 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00309.txt.bz2 On 2017-09-11 02:33, Tom Tromey wrote: > This renames a few functions -- skip_spaces_const, > skip_to_space_const, get_number_const, extract_arg_const -- to drop > the "_const" suffix and instead rely on overloading. > > This makes future const fixes simpler by reducing the number of lines > that must be changed. I think it is also not any less clear, as all > these functions have the same interface as their non-const versions by > design. Furthermore there's an example of using an overload in-tree > already, namely check_for_argument. > > This patch was largely created using some perl one-liners; then a few > fixes were applied by hand. LGTM. That was on my mind as well, glad you did it! Simon