From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 00/10] Undefined Behavior Sanitizer, this time with docs
Date: Tue, 09 Oct 2018 10:44:00 -0000 [thread overview]
Message-ID: <4afd7c11-d43d-191a-201f-3ed3db7da38e@redhat.com> (raw)
In-Reply-To: <20181008202245.GC2993@adacore.com>
On 10/08/2018 09:22 PM, Joel Brobecker wrote:
>> FWIW, I built GDB master today and ubsan (from LLVM, not GCC) flagged a
>> use of obstack_blank_fast() in minsyms.c with a negative offset (used to
>> shrink an obstack) when trying to do 'start' on /bin/ls:
>
> On my end, I am working on a resync of AdaCore's "head" version,
> which would include this change as well. My testing shows that
> it revealed some issues; I haven't had a chance to look into them yet
> (next on my list today, hopefully), but this is making me think
> there might be bona fide issues. Getting the location where things
> are happening is pretty nice :).
This also revealed PR 23743:
https://sourceware.org/bugzilla/show_bug.cgi?id=23743
I think the side-effects are blocking/disturbing enough (GDB dies) that I
think the best course of action is to temporarily disable the ubsan by
default until these issues are fixed. Then try re-enabling again, rinse/repeat.
Otherwise, as is, this is sort of imposing that the community prioritizes
fixing these ubsan-exposed bugs, which I think is unreasonable.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-09 10:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 4:44 Tom Tromey
2018-10-02 4:44 ` [PATCH v2 07/10] Avoid undefined behavior in read_signed_leb128 Tom Tromey
2018-10-02 4:44 ` [PATCH v2 04/10] Avoid undefined behavior in extract_integer Tom Tromey
2018-10-02 4:44 ` [PATCH v2 03/10] Use unsigned as base type for some enums Tom Tromey
2018-10-03 17:33 ` Pedro Alves
2018-10-03 21:07 ` Tom Tromey
2018-10-02 4:44 ` [PATCH v2 01/10] Do not pass NULL to memcpy Tom Tromey
2018-10-02 4:44 ` [PATCH v2 08/10] Avoid undefined behavior in ada_operator_length Tom Tromey
2018-10-02 4:44 ` [PATCH v2 05/10] Avoid undefined behavior in read_subrange_type Tom Tromey
2018-10-02 4:44 ` [PATCH v2 06/10] Avoid undefined behavior in parse_number Tom Tromey
2018-10-02 4:44 ` [PATCH v2 10/10] Add --enable-ubsan Tom Tromey
2018-10-02 13:53 ` Eli Zaretskii
2018-10-02 21:26 ` Tom Tromey
2018-10-02 21:28 ` Tom Tromey
2018-10-03 17:31 ` Eli Zaretskii
2018-10-03 17:54 ` Pedro Alves
2018-10-03 21:09 ` Tom Tromey
2018-10-02 4:44 ` [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector Tom Tromey
2018-10-03 17:28 ` Pedro Alves
2018-10-03 21:05 ` Tom Tromey
2018-10-02 4:44 ` [PATCH v2 09/10] Avoid undefined behavior in expression dumping Tom Tromey
2018-10-03 17:48 ` Pedro Alves
2018-10-03 17:57 ` [PATCH v2 00/10] Undefined Behavior Sanitizer, this time with docs Pedro Alves
2018-10-03 21:09 ` Tom Tromey
2018-10-08 19:14 ` John Baldwin
2018-10-08 20:22 ` Joel Brobecker
2018-10-09 10:44 ` Pedro Alves [this message]
2018-10-12 21:07 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afd7c11-d43d-191a-201f-3ed3db7da38e@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox