Re: [RFC 7/7] Add S390 support for linux-kernel target

Andreas Arnez
2017-02-06T18:48:20Z

On Mon, Feb 06 2017, Yao Qi wrote:

> On 17-01-12 11:08:59, Luis Machado wrote:
>> On 01/12/2017 05:32 AM, Philipp Rudo wrote:
>> >
>> >diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
>> >index 054c6d5..f436a74 100644
>> >--- a/gdb/s390-linux-tdep.c
>> >+++ b/gdb/s390-linux-tdep.c
>>
>> I wonder if we should put the new lk-specific code in its own file,
>> like s390-lk-tdep.c or something. It would make thing a bit more
>> clear and would pollute the current s390-linux-tdep.c file?
>>
>
> +1.

+1.

The Linux kernel runtime will be the second "operating system" supported
by GDB for the s390/s390x architectures. So if we stick to the usual
naming, we will have three components instead of one:

1. s390-tdep -- common
2. s390-linux-tdep -- Linux user-space-specific
3. s390-lk-tdep -- Linux kernel-specific

--
Andreas