From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120218 invoked by alias); 4 May 2018 18:16:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120182 invoked by uid 89); 4 May 2018 18:16:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=CODE, LOW, HIGH, H*M:6f97 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 18:16:47 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAE7D4015A4C; Fri, 4 May 2018 18:16:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 553AD11166F9; Fri, 4 May 2018 18:16:45 +0000 (UTC) Subject: Re: [RFA 04/12] Update memattr.c help strings To: Tom Tromey , gdb-patches@sourceware.org References: <20180430143731.30007-1-tom@tromey.com> <20180430143731.30007-5-tom@tromey.com> From: Pedro Alves Message-ID: <4ac45e86-d5c0-6f97-a72c-d6f0f79a3e26@redhat.com> Date: Fri, 04 May 2018 18:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180430143731.30007-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00118.txt.bz2 On 04/30/2018 03:37 PM, Tom Tromey wrote: > This changes memattr.c to use the GNU style for help strings. > > 2018-04-29 Tom Tromey > > * memattr.c (_initialize_mem): Update help string. > --- > gdb/ChangeLog | 4 ++++ > gdb/memattr.c | 14 +++++++------- > 2 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/gdb/memattr.c b/gdb/memattr.c > index 8dad38b039..328a63a19d 100644 > --- a/gdb/memattr.c > +++ b/gdb/memattr.c > @@ -603,27 +603,27 @@ _initialize_mem (void) > Define attributes for memory region or reset memory region handling to\n\ > target-based.\n\ > Usage: mem auto\n\ > - mem [ ],\n\ > -where may be rw (read/write), ro (read-only) or wo (write-only),\n\ > - may be 8, 16, 32, or 64, and\n\ > - may be cache or nocache")); > + mem LOW HIGH [MODE WIDTH CACHE],\n\ > +where MODE may be rw (read/write), ro (read-only) or wo (write-only),\n\ > + WIDTH may be 8, 16, 32, or 64, and\n\ > + CACHE may be cache or nocache")); > > add_cmd ("mem", class_vars, enable_mem_command, _("\ > Enable memory region.\n\ > Arguments are the code numbers of the memory regions to enable.\n\ > -Usage: enable mem ...\n\ > +Usage: enable mem [CODE]...\n\ > Do \"info mem\" to see current list of code numbers."), &enablelist); > > add_cmd ("mem", class_vars, disable_mem_command, _("\ > Disable memory region.\n\ > Arguments are the code numbers of the memory regions to disable.\n\ > -Usage: disable mem ...\n\ > +Usage: disable mem [CODE]...\n\ > Do \"info mem\" to see current list of code numbers."), &disablelist); > > add_cmd ("mem", class_vars, delete_mem_command, _("\ > Delete memory region.\n\ > Arguments are the code numbers of the memory regions to delete.\n\ > -Usage: delete mem ...\n\ > +Usage: delete mem [CODE]...\n\ > Do \"info mem\" to see current list of code numbers."), &deletelist); > I was surprised and confused with the references to "code" and "code numbers" here. These are just the numbers as displayed in the first column of "info mem", right? How about changing the references to "code numbers" and "CODE" above to numbers or IDs? The manuals uses "nums". Thanks, Pedro Alves