From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id CC1F03A69C05 for ; Fri, 17 Jul 2020 14:20:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CC1F03A69C05 Received: by mail-qk1-x731.google.com with SMTP id e13so8869451qkg.5 for ; Fri, 17 Jul 2020 07:20:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8969fsSqZSdjbX3SWgetTvuY7OaAJQL8DIqOMTTxI8Y=; b=XnWgwLKg6HtZL5KpyPWU1zZUx+WI4bzcJ1RywqLbRrNfGbGlz/UM9PbhmsrnuLOvvT OTLIKM8lvN0LgKrHcMCs/d95KbpahTopXG5F+NrAWjuezBEBajzNAia7t2KWWec+CsvD vGiJHAG27YZoV/pOBOPLYd6aaxWCYDnoHfqnr1k0+JyIgWVLncuxtjOuVfEkPvc4Mt1I 1z2Q5RePpaPJK/O6PtzOp3ShIZdD7o7PifdtsG0aryzffna2o1WDWsz2kw01yT8lEM3r HqwlgETNLsfdQdNeOIFlXrhG0B65tbM+ftSFTn8+p5wELG8ipD6iFnwuSe5jg1uCbMDh qetA== X-Gm-Message-State: AOAM533SPv06FfCiMtbTNmMNJcaiRQZJ50YrwXF3XEti8tcrKJAliqGE 4UmALgWfKiGQMfcKGmdPUUIBzw== X-Google-Smtp-Source: ABdhPJwCRg0bimBnQnpu6iN6ZToam+RlDxGvJSkovr/YvHrp+ObZB+C5WljU8sL6R0ZqQDBKzQmZlg== X-Received: by 2002:a37:dcc:: with SMTP id 195mr8970786qkn.251.1594995636393; Fri, 17 Jul 2020 07:20:36 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:82c3:30f9:c348:a8bc:88d6? ([2804:7f0:8283:82c3:30f9:c348:a8bc:88d6]) by smtp.gmail.com with ESMTPSA id x34sm10901210qtd.44.2020.07.17.07.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 07:20:35 -0700 (PDT) From: Luis Machado Subject: Re: [PATCH 21/23] Document new "x" and "print" memory tagging extensions To: Eli Zaretskii Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com, catalin.marinas@arm.com, david.spickett@linaro.org References: <20200715194513.16641-1-luis.machado@linaro.org> <20200715194513.16641-22-luis.machado@linaro.org> <83h7u6k6oa.fsf@gnu.org> Message-ID: <4ab5c0f4-26fd-94e2-d574-ec15aacc486b@linaro.org> Date: Fri, 17 Jul 2020 11:20:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83h7u6k6oa.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 14:20:38 -0000 On 7/17/20 3:16 AM, Eli Zaretskii wrote: >> Date: Wed, 15 Jul 2020 16:45:11 -0300 >> From: Luis Machado via Gdb-patches >> Cc: catalin.marinas@arm.com, david.spickett@linaro.org >> >> +If the architecture supports memory tagging, the @code{print} command will >> +display pointer/memory tag mismatches if what is being printed is a pointer >> +or reference type. > > Please add here a cross reference to the "Memory Tagging" subsection. > Done. >> +If the architecture supports memory tagging, the tags can be displayed by >> +using @samp{m}. > > Ditto. > Done. >> +Due to the way @value{GDBN} prints information with the @code{x} command (not >> +aligned to a particular boundary), the tag information will refer to the >> +initial address displayed on a particular line. If a memory tag boundary >> +is crossed in the middle of a line displayed by the @code{x} command, it >> +will be displayed in the next line. > ^^^^^^^^^^^^^^^^ > "on the next line" > Fixed. >> +The @code{print} and @code{x} commands will display tag information when > > And here please add a cross-reference to the nodes that describe the > 'print' and 'x' commands. > I added "@cindex Data" (for print) and "@cindex Memory" (for x) locally. >> +The @code{print} command will automatically attempt to validate the logical >> +tag against the allocation tag for pointers and addresses, and will display >> +a message in case of failure. >> + >> +The @code{x} command has a @code{m} modifier. When present, this modifier >> +will make the @code{x} command output allocation tag information for a given >> +memory region that is being examined. > > These should be in the sections that describe these commands, not > here. The idea is to have everything about each command in a single > place, and then point there via cross-references from related places. > > Thanks. > That makes sense. I wanted to make it obvious that memory tagging provided some extra functionality to "print" and "x". I suppose I'll just remove these two blocks since their content is already described in both commands, although with slightly different text.