From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EbB6FbQgYGl2QjMAWB0awg (envelope-from ) for ; Thu, 08 Jan 2026 16:25:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1767907508; bh=gOI9kdRnQCxHwd057O1RcdkvMhy0SZA0wVeLIrSj+sg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Ve85tbIv25zjtOTEaFdLHSKVRHrrpiDslhMCNfiSxYKKCgxsmfnKs6d2+MebAUXnS LjMD6vPCGV6byoeSL7enkwWlDknJPcvAsNFhVwcfAJr/OtSPydCjdJt+P+JCmq5s9b FQ/IcGX4aj40RQsbzUv1dpAgma/yaQYEBCqrCgl0= Received: by simark.ca (Postfix, from userid 112) id 53F2D1E0B6; Thu, 08 Jan 2026 16:25:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=bJBizDtS; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE8831E08D for ; Thu, 08 Jan 2026 16:25:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 616F64BA2E1F for ; Thu, 8 Jan 2026 21:25:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 616F64BA2E1F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=bJBizDtS Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 84E374BA2E05 for ; Thu, 8 Jan 2026 21:24:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84E374BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84E374BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767907481; cv=none; b=XTAiQ5xYHoZ2IAatIS/NWhBtvwVWkjQbgMesiQOSQLxt3jWC4xyjugW56UsViX298AYL45AvQrC2YJL7Eo+BzE/hXjA+nH6PEt3yeCLuaQSyrpbH496Ums2+2WUSooztwrCs9xknUaEig234zX6cNhi2WrqOq6heDnSFy0fFcYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767907481; c=relaxed/simple; bh=gOI9kdRnQCxHwd057O1RcdkvMhy0SZA0wVeLIrSj+sg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ERqBoxta9ZY2kye9XtwwXV2zs/+LnORKzF3Z+od1AfDOURmJdXhbCeGQNZAoE8P0X6p0cectn39b46HwcRbaC/lApK8pkqK55ae085F5Se2awwged5W3efAPUPCcEmgwW6XLNqExJCHTILzgihynuSzRPg5bcusaGbJiEfxaAuo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84E374BA2E05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1767907477; bh=gOI9kdRnQCxHwd057O1RcdkvMhy0SZA0wVeLIrSj+sg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bJBizDtSTG2p8T+zi9uwi4PDTPo9mIyqmRuaCZHytDjrA51ZYx/8kB8Dc3HdSfehd dJQtnGCidVoLtjQ96kkUR1ZMtGUK0rBc3o+orDugeEBY0qyBJPa/JhKx3jzx5ReNeF OwjTEfUgHDdX3nXWEjNOPKqM/D633bwIiu8nnlqY= Received: by simark.ca (Postfix) id BEDAF1E08D; Thu, 08 Jan 2026 16:24:36 -0500 (EST) Message-ID: <4a8db879-e6cb-49d7-a084-ad73da2d1654@simark.ca> Date: Thu, 8 Jan 2026 16:24:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] gdb/xcoffread: remove xcoff_symfile_info::{symtbl, symtbl_num_syms} To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260108193507.553779-1-simon.marchi@efficios.com> <20260108193507.553779-5-simon.marchi@efficios.com> <87h5svon90.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87h5svon90.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/8/26 3:36 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> It is not necessary to save the symbol table content and number of > Simon> symbols in xcoff_symfile_info, because they are only needed for the > Simon> duration of scan_xcoff_symtab. > > Simon> Move the reading of the symbol table content to scan_xcoff_symtab, and > Simon> keep everything as local variables. > > Simon> + /* Seek to symbol table location. */ > Simon> + if (int ret = bfd_seek (abfd, symtab_offset, SEEK_SET); > Simon> + ret < 0) > Simon> + error (_("Error reading symbols from %s: %s"), > Simon> + objfile_name (objfile), bfd_errmsg (bfd_get_error ())); > > 'ret' doesn't really seem to be needed here. What do you mean, not needed? Don't we want to check the return value of bfd_seek? Simon