From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bcDTFPDAiGBpFgAAWB0awg (envelope-from ) for ; Tue, 27 Apr 2021 21:57:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 480461F11C; Tue, 27 Apr 2021 21:57:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A21C91E783 for ; Tue, 27 Apr 2021 21:57:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08D81385781C; Wed, 28 Apr 2021 01:57:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08D81385781C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619575023; bh=wv3lB/ywgzOSu+GdL4Ma2F0u6RFHsAPuR697UjVyn2c=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ZuTdOhqh+DZU+7+oaKFqbbYtxwib9gHupcMeEpPWYc4GWdz/frl6jkJlX+oxl1kKY MpglT8byoOsbnlzt7D+EiO1XNIyp/dLQ1vtEFI4CaCWQEiR7gNW9FdYHZPezPDzwPt nw7C5E3XGRPPW57ivmSVa5PkOBlgsi0uWPb8DvEE= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 905A53857027 for ; Wed, 28 Apr 2021 01:57:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 905A53857027 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13S1urXt018619 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 21:56:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13S1urXt018619 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D585D1E783; Tue, 27 Apr 2021 21:56:53 -0400 (EDT) Subject: Re: [PATCH 13/43] Move piece_closure and its support to expr.c To: Zoran Zaric , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-14-Zoran.Zaric@amd.com> Message-ID: <4a7b94fb-0940-4640-db41-198303a4fc4d@polymtl.ca> Date: Tue, 27 Apr 2021 21:56:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301144620.103016-14-Zoran.Zaric@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 28 Apr 2021 01:56:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-01 9:45 a.m., Zoran Zaric via Gdb-patches wrote: > @@ -300,4 +301,15 @@ extern const gdb_byte *safe_read_sleb128 (const gdb_byte *buf, > extern const gdb_byte *safe_skip_leb128 (const gdb_byte *buf, > const gdb_byte *buf_end); > > +extern const struct lval_funcs pieced_value_funcs; > + > +/* Allocate a closure for a value formed from separately-described > + PIECES. */ > + > +struct piece_closure *allocate_piece_closure > + (dwarf2_per_cu_data *per_cu, > + dwarf2_per_objfile *per_objfile, > + std::vector &&pieces, > + struct frame_info *frame); Indent with two columns: struct piece_closure *allocate_piece_closure (dwarf2_per_cu_data *per_cu, dwarf2_per_objfile *per_objfile, std::vector &&pieces, struct frame_info *frame); > @@ -96,8 +89,7 @@ enum debug_loc_kind > DEBUG_LOC_INVALID_ENTRY = -2 > }; > > -/* Helper function which throws an error if a synthetic pointer is > - invalid. */ > +/* See loc.h. */ > > static void > invalid_synthetic_pointer (void) I don't think you wanted to change this comment. > @@ -286,4 +278,13 @@ extern int dwarf_reg_to_regnum (struct gdbarch *arch, int dwarf_reg); > extern int dwarf_reg_to_regnum_or_error (struct gdbarch *arch, > ULONGEST dwarf_reg); > > +/* Fetch the value pointed to by a synthetic pointer. */ > + > +extern struct value *indirect_synthetic_pointer > + (sect_offset die, LONGEST byte_offset, > + dwarf2_per_cu_data *per_cu, > + dwarf2_per_objfile *per_objfile, > + struct frame_info *frame, > + struct type *type, bool resolve_abstract_p = false); This would typically have two columns of indent: extern struct value *indirect_synthetic_pointer (sect_offset die, LONGEST byte_offset, dwarf2_per_cu_data *per_cu, dwarf2_per_objfile *per_objfile, struct frame_info *frame, struct type *type, bool resolve_abstract_p = false); Although I found one instance in this file of a declaration formatted like you did, it can be confusing. Simon