From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163030-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 101162 invoked by alias); 13 Jan 2020 19:00:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 101072 invoked by uid 89); 13 Jan 2020 19:00:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:632
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 19:00:29 +0000
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 8A4CD1E4C2;	Mon, 13 Jan 2020 14:00:26 -0500 (EST)
Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
References: <20200110220027.26450-1-simon.marchi@efficios.com> <b5ce4f4b-e916-cc68-c344-2a00fae0bb80@simark.ca> <87tv4zp8g0.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <4a47d1c5-61d1-9022-12c2-a37f494861a7@simark.ca>
Date: Mon, 13 Jan 2020 19:10:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <87tv4zp8g0.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2020-01/txt/msg00344.txt.bz2

On 2020-01-13 12:33 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
> Simon> As I tried building gdbserver with a few cross compilers, I found another
> Simon> build issue, with code generated by regdat.sh.  The following patch addresses
> Simon> it.  It should not be too controversial, but I wanted to run it by you first.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* regformats/regdat.sh: Generate declaration for init function.
> 
> This is fine by me.  I agree with your analysis in the commit message.

Thanks, I pushed this patch.

Simon