[PATCH 0/9 V3] Use reinsert breakpoint for vCont;s

Yao Qi
2016-06-30T14:09:43Z

Here is the V3 of this patch series, V2 can be found
https://sourceware.org/ml/gdb-patches/2016-06/msg00029.html
some preparatory patches in V2 are already pushed in. Patches
1 - 5 and 9 are already approved in V2 review.

This patch series is to address the review comments
https://sourceware.org/ml/gdb-patches/2016-06/msg00305.html

> Hmm, seeing that we need to handle installing the breakpoints in
> both places, I wonder about making linux_resume just handle
> setting up the last resume kind and queue signals, and then
> end up calling proceed_all_lwps. If that works, I suspect it
> would simplify things a good deal.

I do something slightly differently in V3. In my
"V2 Use reinsert breakpoint for vCont;s", I install reinsert breakpoints
for needed lwps in two places, linux_resume and proceed_all_lwps, which
isn't ideal.

After the chat with Pedro, we don't need to stop all threads when inserting
reinsert breakpoint, so we can move the breakpoint installation further
down to linux_resume_one_thread and proceed_one_lwp. If
linux_resume_one_thread can use proceed_one_lwp, we can only install
reinsert breakpoints in one place, proceed_one_lwp. Patch 7 changes
linux_resume_one_thread enqueues signal and calls proceed_one_lwp.
Patch 6 is a refactor one to use existing api enqueue_pending_signal.
With the changes in patch 7, patch 8 is simplified compared with V2.

Regression tested on arm-linux and x86_64-linux.

*** BLURB HERE ***

Yao Qi (9):
Pass breakpoint type in set_breakpoint_at
Create sub classes of 'struct breakpoint'
Refactor clone_all_breakpoints
Make reinsert_breakpoint thread specific
Switch current_thread to lwp's thread in
install_software_single_step_breakpoints
Use enqueue_pending_signal in linux_resume_one_thread
Enqueue signal even when resuming threads
Use reinsert_breakpoint for vCont;s
Support vCont s and S actions with software single step

gdb/gdbserver/ChangeLog | 73 +++++++++++
gdb/gdbserver/gdbthread.h | 3 +
gdb/gdbserver/inferiors.c | 14 ++-
gdb/gdbserver/inferiors.h | 2 +-
gdb/gdbserver/linux-low.c | 124 +++++++++---------
gdb/gdbserver/mem-break.c | 313 +++++++++++++++++++++++++++++++++-------------
gdb/gdbserver/mem-break.h | 45 +++----
gdb/gdbserver/server.c | 17 +--
8 files changed, 410 insertions(+), 181 deletions(-)

--
1.9.1