Re: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s

Yao Qi
2016-07-21T11:18:22Z

On Thu, Jun 30, 2016 at 3:09 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Here is the V3 of this patch series, V2 can be found
> https://sourceware.org/ml/gdb-patches/2016-06/msg00029.html
> some preparatory patches in V2 are already pushed in. Patches
> 1 - 5 and 9 are already approved in V2 review.
>
> This patch series is to address the review comments
> https://sourceware.org/ml/gdb-patches/2016-06/msg00305.html
>
>> Hmm, seeing that we need to handle installing the breakpoints in
>> both places, I wonder about making linux_resume just handle
>> setting up the last resume kind and queue signals, and then
>> end up calling proceed_all_lwps. If that works, I suspect it
>> would simplify things a good deal.
>
> I do something slightly differently in V3. In my
> "V2 Use reinsert breakpoint for vCont;s", I install reinsert breakpoints
> for needed lwps in two places, linux_resume and proceed_all_lwps, which
> isn't ideal.
>
> After the chat with Pedro, we don't need to stop all threads when inserting
> reinsert breakpoint, so we can move the breakpoint installation further
> down to linux_resume_one_thread and proceed_one_lwp. If
> linux_resume_one_thread can use proceed_one_lwp, we can only install
> reinsert breakpoints in one place, proceed_one_lwp. Patch 7 changes
> linux_resume_one_thread enqueues signal and calls proceed_one_lwp.
> Patch 6 is a refactor one to use existing api enqueue_pending_signal.
> With the changes in patch 7, patch 8 is simplified compared with V2.
>
> Regression tested on arm-linux and x86_64-linux.
>

I pushed them in.

--
Yao (齐尧)