From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88602 invoked by alias); 27 Jun 2017 10:25:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86763 invoked by uid 89); 27 Jun 2017 10:25:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1028, inclusive X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 10:25:03 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AED34AE9A; Tue, 27 Jun 2017 10:25:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5AED34AE9A Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5AED34AE9A Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A9D6083177; Tue, 27 Jun 2017 10:25:01 +0000 (UTC) Subject: Re: [PATCH 02/40] Eliminate make_cleanup_obstack_free, introduce auto_obstack To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-3-git-send-email-palves@redhat.com> <86o9tax3m1.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4a11c4b0-4bbf-d329-d5e2-46c76dcf7e69@redhat.com> Date: Tue, 27 Jun 2017 10:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86o9tax3m1.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00718.txt.bz2 On 06/26/2017 02:47 PM, Yao Qi wrote: > Pedro Alves writes: > > [I am not sure how many patches in the series I can review, so I may > stop at any point.] Thanks. I think patches #1 to #10 and #19 to #23 (inclusive), could go in independently of the main completer and symbol lookup changes. > >> These changes in the parsers may not be obvious: >> >> - obstack_init (&name_obstack); >> - make_cleanup_obstack_free (&name_obstack); >> + name_obstack.clear (); >> >> Here, the 'name_obstack' variable is a global. The change means that >> the obstack's contents from a previous parse will stay around until >> the next parsing starts. I.e., memory won't be reclaimed until them. >> I don't think that's a problem, these objects don't really grow much >> at all. > > I don't have a better solution to this, so I have to say that your patch > is good enough. Patch is good to me. Thanks, I've pushed this one in. -- Pedro Alves