From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23630 invoked by alias); 15 Jun 2012 19:02:05 -0000 Received: (qmail 23621 invoked by uid 22791); 15 Jun 2012 19:02:04 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jun 2012 19:01:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5FJ1nR1019106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Jun 2012 15:01:49 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5FJ1l6I007083; Fri, 15 Jun 2012 15:01:48 -0400 Message-ID: <4FDB869B.3080802@redhat.com> Date: Fri, 15 Jun 2012 19:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Remove socket file at exit. References: <1339246002-1987-1-git-send-email-yao@codesourcery.com> <1339246002-1987-3-git-send-email-yao@codesourcery.com> <4FD75CD8.4020704@redhat.com> <201206142243.42819.yao@codesourcery.com> In-Reply-To: <201206142243.42819.yao@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00523.txt.bz2 On 06/14/2012 03:43 PM, Yao Qi wrote: > At first, I tried to avoid introducing a global variable, so I inlined that > function. Forgot to revert change back. Fixed. Thanks. > > gdb/gdbserver: > > 2012-06-14 Yao Qi > > * tracepoint.c (agent_socket_name): New static variable. > (gdb_agent_socket_init): Replace local variable 'name' with > 'agent_socket_name'. > Include 'stdlib.h'. > (gdb_agent_remove_socket): New. > (gdb_agent_helper_thread): Install gdb_agent_remove_socket to > atexit hook. This is okay. -- Pedro Alves