From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23474 invoked by alias); 13 Jun 2012 17:54:34 -0000 Received: (qmail 23429 invoked by uid 22791); 13 Jun 2012 17:54:32 -0000 X-SWARE-Spam-Status: No, hits=0.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RCVD_IN_NIX_SPAM X-Spam-Check-By: sourceware.org Received: from marlborough.cnchost.com (HELO marlborough.cnchost.com) (207.155.248.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 17:54:13 +0000 Received: (ConcentricHost relay 1.2); with ESMTP id 49EA72E1A; Wed, 13 Jun 2012 13:54:12 -0400 (EDT) Received: from valrhona.uglyboxes.com (w220.z064001192.sea-wa.dsl.cnc.net [64.1.192.220]) (Authenticated sender: kseitz@uglyboxes.com) by marlborough.cnchost.com (ConcentricHost(2.70) Relay) with ESMTP id 49EA72E1A for ; Wed, 13 Jun 2012 13:54:12 -0400 (EDT) Message-ID: <4FD8D3C2.4090001@uglyboxes.com> Date: Wed, 13 Jun 2012 17:54:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA] breakpoints/13798 and mi/11541 (tests only) Content-Type: multipart/mixed; boundary="------------060907090209090309080903" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00426.txt.bz2 This is a multi-part message in MIME format. --------------060907090209090309080903 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 446 Hi, Both of the bugs involve filenames with spaces and colons. The linespec parser rewrite fixed these bugs, and while there were a few tests that dealt with these cases already, I'd like to add a couple more just to cover some additional bases. Ok? testsuite/ChangeLog 2012-06-13 Keith Seitz PR breakpoints/13798 and mi/11541 * gdb.linespec/ls-errs.exp: Add a few more tests for filenames with spaces and colons. --------------060907090209090309080903 Content-Type: text/x-patch; name="11541-13798.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="11541-13798.patch" Content-length: 847 Index: testsuite/gdb.linespec/ls-errs.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.linespec/ls-errs.exp,v retrieving revision 1.1 diff -u -p -r1.1 ls-errs.exp --- testsuite/gdb.linespec/ls-errs.exp 5 Apr 2012 18:50:29 -0000 1.1 +++ testsuite/gdb.linespec/ls-errs.exp 13 Jun 2012 17:53:14 -0000 @@ -116,7 +116,9 @@ foreach x [list "this_file_doesn't_exist "\"this \"file\" has quotes.c\"" \ "'this \"file\" has quotes.c'" \ "'this 'file' has quotes.c'" \ - "\"this 'file' has quotes.c\""] { + "\"this 'file' has quotes.c\"" \ + "\"spaces: and :colons.c\"" \ + "'more: :spaces: :and colons::.c'"] { # Remove any quoting from FILENAME for the error message. add the_tests "$x:3" invalid_file [string trim $x \"'] } --------------060907090209090309080903--