From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25301 invoked by alias); 13 Jun 2012 12:33:32 -0000 Received: (qmail 25280 invoked by uid 22791); 13 Jun 2012 12:33:28 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 12:33:16 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5DCXCAa016423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 08:33:12 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5DCXAPk031807; Wed, 13 Jun 2012 08:33:11 -0400 Message-ID: <4FD88886.9030803@redhat.com> Date: Wed, 13 Jun 2012 12:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Iain Sandoe CC: gdb-patches@sourceware.org Subject: Re: [RFA, Patch, testsuite] gdb.base/list.exp: initial state test for stub targets. References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00398.txt.bz2 On 06/13/2012 01:23 PM, Iain Sandoe wrote: > Hi, > > At present, gdb.base/list.exp behaves differently for targets that use a stub and those that are native, simulator or gdbserver. > > For the latter cases, the test does not cause an inferior to be created, and the default list lines around main works 'as expected'. > > For the stub case, an inferior is created and this will generally be stopped in some start-up or exception code. At present, this is handled by running to main and then skipping the default listing, unsupport-ing the 'default list lines around main' test. > > I was asked to look into removing that 'unsupported'. > > One way to make things consistent would be to avoid creating the inferior for the stub case - since the listing tests only require host-side actions. This could be achieved by replacing the gdb_load in the test with a gdb_file_cmd, in the test; Patch (a) below. I prefer this option, for removing the special casing, making everything work the same everywhere (and making the test run a little bit faster). > comments/OK for (a) or (b)? > gdb/testsuite: > > * gdb.base/list.exp (test_listsize): Adjust to allow testing of default > lines on targets using stubs. > Okay for (a) from me. But the ChangeLog entry should say what you did, not why you did it. Something like: * gdb.base/list.exp (test_listsize): Remove $use_gdb_stub special case. (top level): Use gdb_file_cmd instead of gdb_load. -- Pedro Alves