From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27989 invoked by alias); 11 Jun 2012 16:09:48 -0000 Received: (qmail 27968 invoked by uid 22791); 11 Jun 2012 16:09:45 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 16:09:31 +0000 Received: (qmail 12555 invoked from network); 11 Jun 2012 09:09:30 -0700 Received: from c-76-102-3-160.hsd1.ca.comcast.net (HELO redwood.eagercon.com) (76.102.3.160) by shell4.bayarea.net with SMTP; 11 Jun 2012 09:09:30 -0700 Message-ID: <4FD61839.80500@eagerm.com> Date: Mon, 11 Jun 2012 16:09:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: "gdb-patches@sourceware.org" , Pedro Alves Subject: Re: [PATCH] MIPS Linux signals References: <4FC9244F.1080704@eagerm.com> <4FC947AE.2000008@eagerm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00295.txt.bz2 On 06/06/2012 03:52 PM, Maciej W. Rozycki wrote: > On Fri, 1 Jun 2012, Michael Eager wrote: > > I find this unreadable (and buggy too, which is likely a consequence), > per observations above please rewrite this as below: > > if (signo>= MIPS_SIGRTMIN&& signo<= MIPS_SIGRTMAX) > { > /* GDB_SIGNAL_REALTIME values are not contiguous, map parts of > the MIPS block to the respective GDB_SIGNAL_REALTIME blocks. */ > signo -= MIPS_SIGRTMIN; > if (signo == 0) > return GDB_SIGNAL_REALTIME_32; > else if (signo< 32) > return ((enum gdb_signal) (signo - 1 + (int) GDB_SIGNAL_REALTIME_33)); > else > return ((enum gdb_signal) (signo - 32 + (int) GDB_SIGNAL_REALTIME_64)); > } > > return GDB_SIGNAL_UNKNOWN; > } > > -- the casts are probably redundant, but let them stay. > > OK with this change, the rest is fine with me. Thanks for tackling this > problem. Checked in with indicated changes. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077