Re: [PATCH 1/4] New gdb arch hook: return_with_first_hidden_param_p

Tom Tromey
2012-05-16T21:03:59Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Now, because I don't know the C++ ABI at all, I don't know whether
Joel> it is expected that some architectures would have a hidden parameter
Joel> for the return value, while some don't. Is that allowed? Regardless,
Joel> it sounds like a gdbarch method would the logical approach... If
Joel> that is the case, I'd rather someone with more knowledge with C++
Joel> did the actual review, because I wouldn't be able to say whether
Joel> the implementation makes sense or not.

Basically what happened is that the ABI was intended to work one way for
C++, but then due to an oversight, some GCC targets applied the same
rule to all languages. So, different arches have different ABIs in
practice. This series, IIUC, just changes gdb to recognize the existing
reality.

Tom