From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12637 invoked by alias); 8 Jun 2012 13:07:37 -0000 Received: (qmail 12625 invoked by uid 22791); 8 Jun 2012 13:07:35 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 13:07:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q58D7GHU024264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Jun 2012 09:07:16 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q58D7EFl024720; Fri, 8 Jun 2012 09:07:15 -0400 Message-ID: <4FD1F902.5000705@redhat.com> Date: Fri, 08 Jun 2012 13:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: "Maciej W. Rozycki" , Joakim Tjernlund , gdb-patches@sourceware.org Subject: Re: [PATCH] solib-svr4: Avoid unwanted shlib internal BPs When debugging Linux kernel or u-boot References: <1338562868-22411-1-git-send-email-Joakim.Tjernlund@transmode.se> <4FC8EC08.1060609@redhat.com> <20120601172214.GA21236@host2.jankratochvil.net> <4FC8FDD2.7060407@redhat.com> <4FD1EB8C.1050407@redhat.com> <20120608123847.GA13337@host2.jankratochvil.net> In-Reply-To: <20120608123847.GA13337@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00228.txt.bz2 On 06/08/2012 01:38 PM, Jan Kratochvil wrote: > I still do not see why 'main' was not left there as it would not hurt and it > could help. The original patch was trivial, and a one liner. I preferred not requiring bigger changes and risk needing to require copyright assignment for that patch. Then, GDB has not been trapping on "main", but on "_start" for static binaries for a long time, so that even feels like a separate "feature" to me. I even feel like we could/should drop the "_start/main" fallback from svr4 handling. It's just historic at this point, as far as I could ascertain. If those are really needed on some system, then a comment in the code mentioning such system is warranted. > OTOH some real world case (some incompatible ld.so state point > name + build) should be given first before finding a solution for it. That's my view too. And if that case would be found, we might find a better solution instead of trapping _start or main. -- Pedro Alves