From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20526 invoked by alias); 7 Jun 2012 13:41:56 -0000 Received: (qmail 20516 invoked by uid 22791); 7 Jun 2012 13:41:55 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jun 2012 13:41:43 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Sccy6-0000eG-QD from Yao_Qi@mentor.com ; Thu, 07 Jun 2012 06:41:42 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 7 Jun 2012 06:41:11 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Thu, 7 Jun 2012 06:41:41 -0700 Message-ID: <4FD0AF8C.2040908@codesourcery.com> Date: Thu, 07 Jun 2012 13:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: oza Pawandeep CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Makefile.in includes linux-record.c to be common for all arch. (arm-reversible>phase-3) References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00215.txt.bz2 On 06/07/2012 11:51 AM, oza Pawandeep wrote: > linux-record.o is added under COMMON_OBS, now -linux-tdep.c compiles. > ok to commit ? I feel it is useless to link linux-record.o for the ports that don't support record at all. If you want to support record in arm-linux, gdb/configure.tgt is the right place to modify, IMO. You need to add "linux-record.o" into gdb_target_obs in "arm*-*-linux*)". -- Yao (齐尧)