From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7477 invoked by alias); 5 Jun 2012 15:38:05 -0000 Received: (qmail 7368 invoked by uid 22791); 5 Jun 2012 15:38:03 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jun 2012 15:37:35 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q55FbZQE015490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Jun 2012 11:37:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q55FbXhs020105; Tue, 5 Jun 2012 11:37:34 -0400 Message-ID: <4FCE27BD.4060405@redhat.com> Date: Tue, 05 Jun 2012 15:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kaushik Srenevasan CC: gdb-patches@sourceware.org Subject: Re: Fix GDB crash while trying to display the return type of a JIT frame. References: <87vcj624dl.fsf@garudatw.twitter.com> In-Reply-To: <87vcj624dl.fsf@garudatw.twitter.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00132.txt.bz2 On 06/04/2012 09:45 PM, Kaushik Srenevasan wrote: > @@ -672,6 +672,7 @@ finalize_symtab (struct gdb_symtab *stab, struct objfile *objfile) > SYMBOL_DOMAIN (block_name) = VAR_DOMAIN; > SYMBOL_CLASS (block_name) = LOC_BLOCK; > SYMBOL_SYMTAB (block_name) = symtab; > + SYMBOL_TYPE (block_name) = lookup_function_type(arch_type(target_gdbarch, TYPE_CODE_VOID, 1, "void")); Pedantically, it'd be better to write 'get_objfile_arch (objfile)' instead of target_gdbarch, even though the objfile's gdbarch is initialized to target_gdbarch presently. -- Pedro Alves