From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11989 invoked by alias); 30 May 2012 18:03:35 -0000 Received: (qmail 11978 invoked by uid 22791); 30 May 2012 18:03:34 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 May 2012 18:03:22 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4UI3KSG008419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 14:03:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4UI3JYn021847; Wed, 30 May 2012 14:03:19 -0400 Message-ID: <4FC660E6.9010904@redhat.com> Date: Wed, 30 May 2012 18:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Thiago Jung Bauermann CC: gdb-patches ml Subject: Re: [RFA] Define DT_MIPS_RLD_MAP if not already defined. References: <1338352816.3618.5.camel@hactar> In-Reply-To: <1338352816.3618.5.camel@hactar> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01046.txt.bz2 On 05/30/2012 05:40 AM, Thiago Jung Bauermann wrote: > Hello, > > Android doesn't support MIPS, so understandably there's no > DT_MIPS_RLD_MAP in its header files. This patch allows gdbserver to be > compiled for Android. Then why not '#ifdef DT_MIPS_RLD_MAP' out the bits that use DT_MIPS_RLD_MAP ? It's just dead code on non-MIPS ports. -- Pedro Alves