From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16628 invoked by alias); 29 May 2012 16:31:58 -0000 Received: (qmail 16604 invoked by uid 22791); 29 May 2012 16:31:52 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 May 2012 16:31:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4TGVAsT000420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 May 2012 12:31:10 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4TGV8x3018508; Tue, 29 May 2012 12:31:09 -0400 Message-ID: <4FC4F9CC.4050003@redhat.com> Date: Tue, 29 May 2012 16:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: Re: RFC for: "Re: Regression for gdb.fortran/library-module.exp [Re: [RFA] choose symbol from given block's objfile first.]" References: <20120514175913.GM10253@adacore.com> <20120514180624.GA16368@host2.jankratochvil.net> <20120515130851.GP10253@adacore.com> <20120516195718.GA10253@adacore.com> <20120518164815.GA11883@host2.jankratochvil.net> <20120528142727.GH5492@adacore.com> <20120528161200.GA19230@host2.jankratochvil.net> <20120529154436.GO5492@adacore.com> <20120529155527.GA9177@host2.jankratochvil.net> <20120529160201.GQ5492@adacore.com> <20120529161140.GA9878@host2.jankratochvil.net> In-Reply-To: <20120529161140.GA9878@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01027.txt.bz2 On 05/29/2012 05:11 PM, Jan Kratochvil wrote: > It should be a pointer to function implementing the functionality - which > differs across platforms: > > M:void:iterate_over_objfiles_in_search_order: iterate_over_objfiles_in_search_order_cb cb, void *cb_data, struct objfile *context_objfile: cb, cb_data, context_objfile > - I did not check it should be very exactly this way like m vs. M etc. > > default implementation: > static void > default_iterate_over_objfiles_in_search_order > (iterate_over_objfiles_in_search_order_cb cb, > void *cb_data, > struct objfile *context_objfile) > { ... > set_gdbarch_iterate_over_objfiles_in_search_order (gdbarch, default_iterate_over_objfiles_in_search_order); > > > ms-windows implementation > > static void > windows_iterate_over_objfiles_in_search_order > (iterate_over_objfiles_in_search_order_cb cb, > void *cb_data, > struct objfile *context_objfile) > { ... > set_gdbarch_iterate_over_objfiles_in_search_order (gdbarch, windows_iterate_over_objfiles_in_search_order); > Agreed. (I'd suggest renaming context_objfile -> current_objfile, as that sounds to me closer to what it really is used for, rather than a generic context, but that's a nit.) -- Pedro Alves