From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3093 invoked by alias); 25 May 2012 19:52:36 -0000 Received: (qmail 3078 invoked by uid 22791); 25 May 2012 19:52:35 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 19:52:20 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4PJqHsY013228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 May 2012 15:52:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4PJqF4u014531; Fri, 25 May 2012 15:52:16 -0400 Message-ID: <4FBFE2EF.2040807@redhat.com> Date: Fri, 25 May 2012 19:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] Add scripts to generate ARI web pages to gdb/contrib/ari directory References: <4fb6d008.8727440a.10f3.1718SMTPIN_ADDED@mx.google.com> In-Reply-To: <4fb6d008.8727440a.10f3.1718SMTPIN_ADDED@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00976.txt.bz2 On 05/18/2012 11:40 PM, Pierre Muller wrote: > Here is a RFA for inclusion of scripts to gdb/contrib/ari. > > The only changes to RFC-v2 are: > 1) directory moved from gdb/ari to gdb/contrib./ari > 2) create-web-ari-in-src.sh adapted to new directory > 3) This script now output that location of the generated > web page (with a different message depending on > the existence of this file). I really don't like the send_email thing. > + if [ "$send_email" == "true" ]; then > + if [ "${node}" = "sourceware.org" ]; then > + warning_email=gdb-patches@sourceware.org > + else > + # Use default email > + warning_email=${USER}@${node} > + fi If the script really needs to know to send email, and where to send it to, it'd be much much better to specify the destination with a command line option. As Joel said, we don't have to use the new gdb/ari scripts from ss immediately. We can keep using the ones in ss until the gdb ones are in shape. Even sending unexpected email to ${USER}@${node} may not be a good idea. I'd vote for leaving the email sending off by default until we have a command line option. Other than that, it doesn't seem to cause anyone trouble to put this stuff in, and work on top. -- Pedro Alves