From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14773 invoked by alias); 24 May 2012 11:59:56 -0000 Received: (qmail 14764 invoked by uid 22791); 24 May 2012 11:59:55 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 May 2012 11:59:42 +0000 Received: from [10.7.0.51] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Thu, 24 May 2012 07:59:41 -0400 Message-ID: <4FBE22AD.4070204@tilera.com> Date: Thu, 24 May 2012 11:59:00 -0000 From: Jeff Kenton User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:6.0.2) Gecko/20110902 Thunderbird/6.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver) References: <4FAD3C4D.9080409@tilera.com> <4FBA5138.4090203@tilera.com> <4FBD2341.2000506@redhat.com> In-Reply-To: <4FBD2341.2000506@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00924.txt.bz2 On 05/23/2012 01:49 PM, Pedro Alves wrote: > On 05/21/2012 03:29 PM, Jeff Kenton wrote: >> * Makefile.in: Add tilegx dependencies. >> * configure.srv: Add tilegx dependencies. >> * linux-tile-low.c: New file. > This needs to be more specific. Something like: > > * Makefile.in (SFILES): Add linux-tile-low.c. > (linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules. > * configure.srv: Handle tilegx-*-linux*. > * linux-tile-low.c: New file. > > > Otherwise looks fine, thanks. > > Same comment about ps_get_thread_area though. > Pedro, How is this different from your comment about ps_get_thread_area in your response to part 2? --jeff kenton