Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver)

Pedro Alves
2012-05-30T20:06:07Z

On 05/29/2012 04:28 PM, Jeff Kenton wrote:

> Updated patch attached.

This lost the ChangeLog changes of the previous iteration, but I think the patch
is the up-to-date one. I've also removed the ps_get_thread_area bit from this.

Here's what I checked in.

I think that's it. I think you already had a NEWS patch at some point.
Could you resend it in a new thread, please?

Thanks!

gdb/gdbserver/

* Makefile.in (SFILES): Add linux-tile-low.c.
(linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules.
* configure.srv: Handle tilegx-*-linux*.
* linux-tile-low.c: New file.
---

diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index 50786d5..3c5c041 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -133,6 +133,7 @@ SFILES= $(srcdir)/gdbreplay.c $(srcdir)/inferiors.c $(srcdir)/dll.c \
$(srcdir)/linux-sh-low.c $(srcdir)/linux-sparc-low.c \
$(srcdir)/linux-x86-low.c \
$(srcdir)/linux-xtensa-low.c \
+ $(srcdir)/linux-tile-low.c \
$(srcdir)/win32-arm-low.c $(srcdir)/win32-i386-low.c \
$(srcdir)/win32-low.c $(srcdir)/wincecompat.c \
$(srcdir)/hostio.c $(srcdir)/hostio-errno.c \
@@ -549,6 +550,7 @@ linux-tic6x-low.o: linux-tic6x-low.c $(linux_low_h) $(server_h)
linux-x86-low.o: linux-x86-low.c $(linux_low_h) $(server_h) \
$(gdb_proc_service_h) $(i386_low_h) $(agent_h)
linux-xtensa-low.o: linux-xtensa-low.c xtensa-xtregs.c $(linux_low_h) $(server_h)
+linux-tile-low.o: linux-tile-low.c $(linux_low_h) $(server_h)

lynx-low.o: lynx-low.c $(server_h) $(target_h) $(lynx_low_h)
lynx-ppc-low.o: lynx-ppc-low.c $(server_h) $(lynx_low_h)
@@ -752,4 +754,7 @@ x32-avx-linux.c : $(srcdir)/../regformats/i386/x32-avx-linux.dat $(regdat_sh)
reg-xtensa.o : reg-xtensa.c $(regdef_h)
reg-xtensa.c : $(srcdir)/../regformats/reg-xtensa.dat $(regdat_sh)
$(SHELL) $(regdat_sh) $(srcdir)/../regformats/reg-xtensa.dat reg-xtensa.c
+reg-tilegx.o : reg-tilegx.c $(regdef_h)
+reg-tilegx.c : $(srcdir)/../regformats/reg-tilegx.dat $(regdat_sh)
+ $(SHELL) $(regdat_sh) $(srcdir)/../regformats/reg-tilegx.dat reg-tilegx.c
# This is the end of "Makefile.in".
diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
index e6ae157..d1e04a9 100644
--- a/gdb/gdbserver/configure.srv
+++ b/gdb/gdbserver/configure.srv
@@ -311,6 +311,12 @@ case "${target}" in
srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
srv_linux_regsets=yes
;;
+ tilegx-*-linux*) srv_regobj=reg-tilegx.o
+ srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o"
+ srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
+ srv_linux_regsets=yes
+ srv_linux_thread_db=yes
+ ;;
*) echo "Error: target not supported by gdbserver."
exit 1
;;
diff --git a/gdb/gdbserver/linux-tile-low.c b/gdb/gdbserver/linux-tile-low.c
new file mode 100644
index 0000000..e7c7d11
--- /dev/null
+++ b/gdb/gdbserver/linux-tile-low.c
@@ -0,0 +1,142 @@
+/* GNU/Linux/TILE-Gx specific low level interface, GDBserver.
+
+ Copyright (C) 2012 Free Software Foundation, Inc.
+
+ This file is part of GDB.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include "server.h"
+#include "linux-low.h"
+
+#include <sys/ptrace.h>
+
+/* Defined in auto-generated file reg-tile.c. */
+void init_registers_tile (void);
+
+#define tile_num_regs 65
+
+static int tile_regmap[] =
+{
+ 0, 1, 2, 3, 4, 5, 6, 7,
+ 8, 9, 10, 11, 12, 13, 14, 15,
+ 16, 17, 18, 19, 20, 21, 22, 23,
+ 24, 25, 26, 27, 28, 29, 30, 31,
+ 32, 33, 34, 35, 36, 37, 38, 39,
+ 40, 41, 42, 43, 44, 45, 46, 47,
+ 48, 49, 50, 51, 52, 53, 54, 55,
+ -1, -1, -1, -1, -1, -1, -1, -1,
+ 56
+};
+
+static int
+tile_cannot_fetch_register (int regno)
+{
+ if (regno >= 0 && regno < 56)
+ return 0;
+ else if (regno == 64)
+ return 0;
+ else
+ return 1;
+}
+
+static int
+tile_cannot_store_register (int regno)
+{
+ if (regno >= 0 && regno < 56)
+ return 0;
+ else if (regno == 64)
+ return 0;
+ else
+ return 1;
+}
+
+static CORE_ADDR
+tile_get_pc (struct regcache *regcache)
+{
+ unsigned long pc;
+
+ collect_register_by_name (regcache, "pc", &pc);
+ return pc;
+}
+
+static void
+tile_set_pc (struct regcache *regcache, CORE_ADDR pc)
+{
+ unsigned long newpc = pc;
+
+ supply_register_by_name (regcache, "pc", &newpc);
+}
+
+static uint64_t tile_breakpoint = 0x400b3cae70166000ULL;
+#define tile_breakpoint_len 8
+
+static int
+tile_breakpoint_at (CORE_ADDR where)
+{
+ uint64_t insn;
+
+ (*the_target->read_memory) (where, (unsigned char *) &insn, 8);
+ if (insn == tile_breakpoint)
+ return 1;
+
+ /* If necessary, recognize more trap instructions here. GDB only uses the
+ one. */
+ return 0;
+}
+
+static void
+tile_fill_gregset (struct regcache *regcache, void *buf)
+{
+ int i;
+
+ for (i = 0; i < tile_num_regs; i++)
+ if (tile_regmap[i] != -1)
+ collect_register (regcache, i, ((unsigned int *) buf) + tile_regmap[i]);
+}
+
+static void
+tile_store_gregset (struct regcache *regcache, const void *buf)
+{
+ int i;
+
+ for (i = 0; i < tile_num_regs; i++)
+ if (tile_regmap[i] != -1)
+ supply_register (regcache, i, ((unsigned long *) buf) + tile_regmap[i]);
+}
+
+struct regset_info target_regsets[] =
+{
+ { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
+ GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
+ { 0, 0, 0, -1, -1, NULL, NULL }
+};
+
+struct linux_target_ops the_low_target =