Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver)

Pedro Alves
2012-05-25T18:18:56Z

On 05/24/2012 08:30 PM, Jeff Kenton wrote:

> diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c ./gdb/gdbserver/linux-tile-low.c
> --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500
> +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400
> @@ -0,0 +1,164 @@
> +
> +

Two spurious empty lines here. Please remove them.

> +/* GNU/Linux/TILE-Gx specific low level interface, GDBserver.

> --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500
> +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400
> +#include "gdb_proc_service.h"
...
> +linux-tile-low.o: linux-tile-low.c $(linux_low_h) $(server_h)

This now needs to depend on $(gdb_proc_service_h) too.

Otherwise looks fine.

--
Pedro Alves