From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29781 invoked by alias); 23 May 2012 11:39:56 -0000 Received: (qmail 29658 invoked by uid 22791); 23 May 2012 11:39:54 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 May 2012 11:39:38 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4NBdVCv026533 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 May 2012 07:39:31 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4NBdRXR002495; Wed, 23 May 2012 07:39:28 -0400 Message-ID: <4FBCCC6F.2080602@redhat.com> Date: Wed, 23 May 2012 11:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Aleksandar Ristovski CC: "Maciej W. Rozycki" , Michael Eager , "gdb-patches@sourceware.org" Subject: Re: MIPS Linux signals References: <4FB850CA.7090701@eagerm.com> <4FBAB500.7010104@redhat.com> <4FBAB948.7000808@eagerm.com> <4FBB712F.2030604@redhat.com> <4FBBE97B.5040400@qnx.com> <4FBC0B45.6050204@redhat.com> <4FBC2127.9030406@qnx.com> In-Reply-To: <4FBC2127.9030406@qnx.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00884.txt.bz2 On 05/23/2012 12:28 AM, Aleksandar Ristovski wrote: >> >> So it sounds like there's no real use for the gdbarch method in _common_ code then, right? If >> that's the case, we should zap it from the FSF tree until we find such a use. >> > Fine by me. Thanks. Applied. 2012-05-23 Pedro Alves * arch-utils.h (default_target_signal_to_host): Delete. * arch-utils.c (default_target_signal_to_host): Delete. * gdbarch.sh (target_signal_to_host): Remove. * gdbarch.h, gdbarch.c: Regenerate. --- gdb/arch-utils.c | 6 ------ gdb/arch-utils.h | 2 -- gdb/gdbarch.c | 24 ------------------------ gdb/gdbarch.h | 7 ------- gdb/gdbarch.sh | 3 --- 5 files changed, 0 insertions(+), 42 deletions(-) diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index fabb515..c6866a9 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -793,12 +793,6 @@ default_gen_return_address (struct gdbarch *gdbarch, error (_("This architecture has no method to collect a return address.")); } -int -default_target_signal_to_host (struct gdbarch *gdbarch, enum target_signal ts) -{ - return target_signal_to_host (ts); -} - enum target_signal default_target_signal_from_host (struct gdbarch *gdbarch, int signo) { diff --git a/gdb/arch-utils.h b/gdb/arch-utils.h index c2c3398..8f47635 100644 --- a/gdb/arch-utils.h +++ b/gdb/arch-utils.h @@ -174,7 +174,5 @@ extern const char *default_auto_wide_charset (void); extern enum target_signal default_target_signal_from_host (struct gdbarch *, int); -extern int default_target_signal_to_host (struct gdbarch *, - enum target_signal); #endif diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c index af2033b..8d009f3 100644 --- a/gdb/gdbarch.c +++ b/gdb/gdbarch.c @@ -261,7 +261,6 @@ struct gdbarch gdbarch_process_record_ftype *process_record; gdbarch_process_record_signal_ftype *process_record_signal; gdbarch_target_signal_from_host_ftype *target_signal_from_host; - gdbarch_target_signal_to_host_ftype *target_signal_to_host; gdbarch_get_siginfo_type_ftype *get_siginfo_type; gdbarch_record_special_symbol_ftype *record_special_symbol; gdbarch_get_syscall_number_ftype *get_syscall_number; @@ -429,7 +428,6 @@ struct gdbarch startup_gdbarch = 0, /* process_record */ 0, /* process_record_signal */ default_target_signal_from_host, /* target_signal_from_host */ - default_target_signal_to_host, /* target_signal_to_host */ 0, /* get_siginfo_type */ 0, /* record_special_symbol */ 0, /* get_syscall_number */ @@ -539,7 +537,6 @@ gdbarch_alloc (const struct gdbarch_info *info, gdbarch->displaced_step_location = NULL; gdbarch->relocate_instruction = NULL; gdbarch->target_signal_from_host = default_target_signal_from_host; - gdbarch->target_signal_to_host = default_target_signal_to_host; gdbarch->has_shared_address_space = default_has_shared_address_space; gdbarch->fast_tracepoint_valid_at = default_fast_tracepoint_valid_at; gdbarch->auto_charset = default_auto_charset; @@ -731,7 +728,6 @@ verify_gdbarch (struct gdbarch *gdbarch) /* Skip verify of process_record, has predicate. */ /* Skip verify of process_record_signal, has predicate. */ /* Skip verify of target_signal_from_host, invalid_p == 0 */ - /* Skip verify of target_signal_to_host, invalid_p == 0 */ /* Skip verify of get_siginfo_type, has predicate. */ /* Skip verify of record_special_symbol, has predicate. */ /* Skip verify of get_syscall_number, has predicate. */ @@ -1345,9 +1341,6 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file) "gdbarch_dump: target_signal_from_host = <%s>\n", host_address_to_string (gdbarch->target_signal_from_host)); fprintf_unfiltered (file, - "gdbarch_dump: target_signal_to_host = <%s>\n", - host_address_to_string (gdbarch->target_signal_to_host)); - fprintf_unfiltered (file, "gdbarch_dump: gdbarch_unwind_pc_p() = %d\n", gdbarch_unwind_pc_p (gdbarch)); fprintf_unfiltered (file, @@ -3812,23 +3805,6 @@ set_gdbarch_target_signal_from_host (struct gdbarch *gdbarch, } int -gdbarch_target_signal_to_host (struct gdbarch *gdbarch, enum target_signal ts) -{ - gdb_assert (gdbarch != NULL); - gdb_assert (gdbarch->target_signal_to_host != NULL); - if (gdbarch_debug >= 2) - fprintf_unfiltered (gdb_stdlog, "gdbarch_target_signal_to_host called\n"); - return gdbarch->target_signal_to_host (gdbarch, ts); -} - -void -set_gdbarch_target_signal_to_host (struct gdbarch *gdbarch, - gdbarch_target_signal_to_host_ftype target_signal_to_host) -{ - gdbarch->target_signal_to_host = target_signal_to_host; -} - -int gdbarch_get_siginfo_type_p (struct gdbarch *gdbarch) { gdb_assert (gdbarch != NULL); diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 5bc4f4d..4388a7d 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -946,13 +946,6 @@ typedef enum target_signal (gdbarch_target_signal_from_host_ftype) (struct gdbar extern enum target_signal gdbarch_target_signal_from_host (struct gdbarch *gdbarch, int signo); extern void set_gdbarch_target_signal_from_host (struct gdbarch *gdbarch, gdbarch_target_signal_from_host_ftype *target_signal_from_host); -/* Signal translation: translate GDB's signal number into inferior's host - signal number. */ - -typedef int (gdbarch_target_signal_to_host_ftype) (struct gdbarch *gdbarch, enum target_signal ts); -extern int gdbarch_target_signal_to_host (struct gdbarch *gdbarch, enum target_signal ts); -extern void set_gdbarch_target_signal_to_host (struct gdbarch *gdbarch, gdbarch_target_signal_to_host_ftype *target_signal_to_host); - /* Extra signal info inspection. Return a type suitable to inspect extra signal information. */ diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 3e3b126..9394677 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -775,9 +775,6 @@ M:int:process_record_signal:struct regcache *regcache, enum target_signal signal # Signal translation: translate inferior's signal (host's) number into # GDB's representation. m:enum target_signal:target_signal_from_host:int signo:signo::default_target_signal_from_host::0 -# Signal translation: translate GDB's signal number into inferior's host -# signal number. -m:int:target_signal_to_host:enum target_signal ts:ts::default_target_signal_to_host::0 # Extra signal info inspection. #