From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18724 invoked by alias); 22 May 2012 18:14:24 -0000 Received: (qmail 18706 invoked by uid 22791); 22 May 2012 18:14:23 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 18:14:09 +0000 Received: (qmail 30119 invoked from network); 22 May 2012 11:14:08 -0700 Received: from c-76-102-3-160.hsd1.ca.comcast.net (HELO redwood.eagercon.com) (76.102.3.160) by shell4.bayarea.net with SMTP; 22 May 2012 11:14:08 -0700 Message-ID: <4FBBD770.6080900@eagerm.com> Date: Tue, 22 May 2012 18:14:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Pedro Alves CC: "Maciej W. Rozycki" , "gdb-patches@sourceware.org" Subject: Re: MIPS Linux signals References: <4FB850CA.7090701@eagerm.com> <4FBAB500.7010104@redhat.com> <4FBAB948.7000808@eagerm.com> <4FBB67AE.5090807@redhat.com> <4FBBB352.6080009@eagerm.com> <4FBBB877.8010109@redhat.com> In-Reply-To: <4FBBB877.8010109@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00841.txt.bz2 On 05/22/2012 09:01 AM, Pedro Alves wrote: >>> target_signal_from_host => gdb_signal_from_host (or gdb_signal_from_host_signal) >>> target_signal_to_host => gdb_signal_to_host (or gdb_signal_to_host_signal) >>> >>> gdbarch_target_signal_from_host => gdbarch_gdb_signal_from_target (or gdbarch_gdb_signal_from_target_signal) >>> gdbarch_target_signal_to_host => gdbarch_gdb_signal_to_target (or gdbarch_gdb_signal_to_target_signal) >> >> OK, but I'd recommend >> target_signal_from_host => gdb_signal_from_target >> target_signal_to_host => gdb_signal_to_target >> >> This is symmetric with the gdbarch_ functions and clear that the function >> translates to/from target system values, not the host system. > > > But it's not what the functions do... They really convert from the host > system signals, not the target's. I think the symmetry will only lead to > people getting confused (which one to call in common/target-independent code?). If you are running GDB on a Windows host, for example, what host system signals are you translating? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077