From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15594 invoked by alias); 22 May 2012 12:39:16 -0000 Received: (qmail 15472 invoked by uid 22791); 22 May 2012 12:39:14 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 12:38:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4MCcUMs031098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 May 2012 08:38:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4MCcTwM013550; Tue, 22 May 2012 08:38:30 -0400 Message-ID: <4FBB88C5.6070900@redhat.com> Date: Tue, 22 May 2012 12:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Pierre Muller , gdb-patches@sourceware.org Subject: Re: [RFA-v2/ARI fix] Remove use of abort function in common/buffer.c References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> <4FBB5D9B.5070202@redhat.com> <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr> <20120522121832.GC5492@adacore.com> In-Reply-To: <20120522121832.GC5492@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00816.txt.bz2 On 05/22/2012 01:18 PM, Joel Brobecker wrote: > Hi Pierre, Hi Pedro, > > Thanks for taking care of this, Pierre. > >> + /* new_buffer is non NULL otherwise >> + xrealloc calls malloc_failure which does not return here. */ > > I suggest a slightly different way of saying this: > > /* xrealloc guaranties that new_buffer cannot be null. */ > > It avoids the problem with the location of the line break and any issue > with punctuation... > Fine with me, but I'd suggest to just say nothing. The whole point of the xrealloc, xmalloc, etc. functions is to abort on failure instead of returning NULL. We have about 150 or so xrealloc calls in the tree, about 70 xcalloc calls, and about 700 xmalloc calls. We don't put just comment on most (any?) of those, and I don't see what makes this particular instance special. -- Pedro Alves