From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7532 invoked by alias); 22 May 2012 09:34:42 -0000 Received: (qmail 7464 invoked by uid 22791); 22 May 2012 09:34:40 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 09:34:23 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4M9YKjk001891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 May 2012 05:34:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4M9YJ9W012660; Tue, 22 May 2012 05:34:19 -0400 Message-ID: <4FBB5D9B.5070202@redhat.com> Date: Tue, 22 May 2012 09:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA/ARI fix] Remove use of abort function in common/buffer.c References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> In-Reply-To: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00810.txt.bz2 On 05/22/2012 10:17 AM, Pierre Muller wrote: > ARI clearly states that abort function > should never be used, and to use internal_error > instead. > > I first suspected that this was related to missing declarations in > common directory, but internal_error does > exist there also. > > Finally, looking at common/buffer.c source, I found that > gdb_assert was probably a better fit here > (the macro does call internal_error). > > > Is this patch OK or what else should we use here? We should just remove the abort; it's dead code. xrealloc already handles that for us. common/common-utils.c:xrealloc: ... /* (...) It never returns NULL. */ ... if (val == NULL) malloc_failure (size); return val; } -- Pedro Alves