From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15867 invoked by alias); 21 May 2012 14:51:12 -0000 Received: (qmail 15857 invoked by uid 22791); 21 May 2012 14:51:11 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 14:50:58 +0000 Received: (qmail 26625 invoked from network); 21 May 2012 07:50:57 -0700 Received: from c-76-102-3-160.hsd1.ca.comcast.net (HELO redwood.eagercon.com) (76.102.3.160) by shell4.bayarea.net with SMTP; 21 May 2012 07:50:57 -0700 Message-ID: <4FBA5651.4070909@eagerm.com> Date: Mon, 21 May 2012 14:51:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: MIPS Linux signals References: <4FB850CA.7090701@eagerm.com> <4FBA2111.8010801@redhat.com> In-Reply-To: <4FBA2111.8010801@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00770.txt.bz2 On 05/21/2012 04:03 AM, Pedro Alves wrote: > On 05/20/2012 03:02 AM, Michael Eager wrote: >> 4 -- Do the multiple layers of wrappers around target_ >> signal_{to,from}_host in signals.c serve any purpose? > > Can you be more specific? What multiple layers? target_signal_to_host() is a wrapper around do_target_signal_to_host(). target_signal_to_host_p() is a wrapper around do_target_signal_to_host(). This appears to be only used in gdbserver, where, on MIPS, it will return the wrong result. Incidentally, gdbserver on MIPS calls the X86 target_signal_to_host() to translate signals. This seems confused. If gdb is translating internal signal numbers to the target signal numbers, then this seems to be a second translation. default_target_signal_to_host() is a wrapper around target_signal_to_host(). default_target_signal_from_host() is a wrapper around target_signal_from_host(). -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077