From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23523 invoked by alias); 16 May 2012 18:28:39 -0000 Received: (qmail 23508 invoked by uid 22791); 16 May 2012 18:28:37 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 May 2012 18:28:22 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4GISAPH012917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 14:28:22 -0400 Received: from [10.36.112.31] (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4GGcR8F014451 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 16 May 2012 12:38:29 -0400 Message-ID: <4FB3D727.9070605@redhat.com> Date: Wed, 16 May 2012 18:28:00 -0000 From: nick clifton User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Sergio Durigan Junior CC: binutils@sourceware.org, gdb-patches@sourceware.org, Pedro Alves Subject: Re: [RFC/PATCH] Fix `bfd_{get,set}_*' macros References: <20120503075305.GJ635@bubble.grove.modra.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00614.txt.bz2 Hi Sergio, > 2012-05-04 Sergio Durigan Junior > > * bfd-in2.h (bfd_get_section_name, bfd_get_section_vma, > bfd_get_section_lma, bfd_get_section_alignment, > bfd_get_section_flags, > bfd_get_section_userdata): Rewrite macros in order to use the > `bfd' argument. > * elf-vxworks.c (elf_vxworks_finish_dynamic_entry): Pass proper `bfd' > as the first argument for `bfd_get_section_alignment'. > * elf32-arm.c (create_ifunc_sections): Likewise, for > `bfd_set_section_alignment'. > * elf32-m32r.c (m32r_elf_relocate_section): Likewise, for > `bfd_get_section_name'. > * elf32-microblaze.c (microblaze_elf_relocate_section): Likewise. > * elf32-ppc.c (ppc_elf_size_dynamic_sections): Likewise. > (ppc_elf_relocate_section): Likewise. > * elf64-mmix.c (mmix_final_link_relocate): Likewise, for > `bfd_get_section_vma'. > * elf64-ppc.c (create_linkage_sections): Likewise, for > `bfd_set_section_alignment'. I have applied this patch. There were however a few problems with it: * You modified bfd-in2.h, an auto-generated file, but not bfd-in.h, the file from which it is generated. * You missed a use of bfd_get_section_name() in bfd/elf32-ppc.c. * You missed a use of bfd_get_section_vma() in gas/config/tc-alpha.c. * You missed two uses of bfd_get_section_name() in ld/emultempl/m68hc1xelf.em. These problems have been fixed. For future reference I recommend building a toolchain configured as "--enable-64-bit-bfd --enable-targets=all" in order to catch problems like these. Cheers Nick