From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: <brobecker@adacore.com>, <gdb-patches@sourceware.org>,
<cltang@codesourcery.com>
Subject: Re: [PATCH 1/4] New gdb arch hook: return_with_first_hidden_param_p
Date: Wed, 16 May 2012 01:55:00 -0000 [thread overview]
Message-ID: <4FB308F4.50602@codesourcery.com> (raw)
In-Reply-To: <201205151802.q4FI2O2Y013475@glazunov.sibelius.xs4all.nl>
On 05/16/2012 02:02 AM, Mark Kettenis wrote:
>> > No, the extra hidden parameter's type is the reference of the function's
>> > return type. My point is if we only examine debug info, we don't know
>> > whether hidden parameter is passed, because the debug info is the same
>> > regardless of hidden parameter is passed or not.
> I'm still very confused. This "hidden parameter" thing sounds exactly
> like "struct_return". So are you saying that on some architectures
> gdbarch_return_value() return RETUN_VALUE_REGISTER_CONVENTION when if
> fact for C++ (and not for plain C) it should return
> RETURN_VALUE_STRUCT_CONVENTION?
In an inferior call, there are two steps related to ABI, 1) passing
parameters, 2) fetching return value. The "hidden parameter" is
relevant to both steps. Your description above is correct, and it is
about step 2. My patches are trying to fix the problems in step 1. So
far, GDB passes hidden parameter for some language, but on some targets,
the hidden parameter is not passed by parameter register, it is passed
by other register specified by its ABI. GDB is wrong if it still pass
hidden parameter to parameter register.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-05-16 1:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 13:28 Yao Qi
2012-04-18 13:18 ` [PATCH 3/4] sh: Install return_with_first_hidden_param_p Yao Qi
2012-05-16 21:00 ` Tom Tromey
2012-04-18 13:18 ` [PATCH 4/4] m68k: " Yao Qi
2012-05-16 21:01 ` Tom Tromey
2012-04-18 13:18 ` [PATCH 2/4] tic6x: " Yao Qi
2012-05-16 20:59 ` Tom Tromey
2012-04-25 11:02 ` [PATCH 1/4] New gdb arch hook: return_with_first_hidden_param_p Yao Qi
2012-05-03 0:43 ` [ping 2] : " Yao Qi
2012-05-03 1:15 ` Joel Brobecker
2012-05-03 7:00 ` Yao Qi
2012-05-04 17:58 ` Joel Brobecker
2012-05-07 3:39 ` Yao Qi
2012-05-07 20:14 ` Joel Brobecker
2012-05-09 8:39 ` Yao Qi
2012-05-10 21:21 ` Joel Brobecker
2012-05-11 10:35 ` Yao Qi
2012-05-14 17:15 ` Joel Brobecker
2012-05-15 6:51 ` Yao Qi
2012-05-15 15:01 ` Joel Brobecker
2012-05-16 1:37 ` Yao Qi
2012-05-16 15:31 ` Joel Brobecker
2012-05-16 21:03 ` Tom Tromey
2012-05-15 18:03 ` Mark Kettenis
2012-05-16 1:55 ` Yao Qi [this message]
2012-05-17 21:02 ` Mark Kettenis
2012-07-06 13:17 ` Gary Benson
2012-05-15 15:35 ` Thomas Schwinge
2012-05-15 21:30 ` Joel Brobecker
2012-05-03 14:04 ` Chung-Lin Tang
2012-05-16 20:56 ` Tom Tromey
2012-05-16 23:03 ` Mark Kettenis
2012-06-08 14:30 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB308F4.50602@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=cltang@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox