From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22730 invoked by alias); 10 May 2012 11:57:19 -0000 Received: (qmail 22722 invoked by uid 22791); 10 May 2012 11:57:18 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 11:57:02 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4ABuw9I024272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 May 2012 07:56:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4ABuu1F001716; Thu, 10 May 2012 07:56:57 -0400 Message-ID: <4FABAD08.5020305@redhat.com> Date: Thu, 10 May 2012 11:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Hui Zhu CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH]testsuite: test for disconnected-tracing References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com> <4F7D8715.9040509@redhat.com> <4F851A22.40809@mentor.com> <4FAB41A5.2020802@mentor.com> In-Reply-To: <4FAB41A5.2020802@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00332.txt.bz2 On 05/10/2012 05:18 AM, Hui Zhu wrote: > On 04/11/12 13:44, Hui Zhu wrote: >> On 04/05/12 19:50, Pedro Alves wrote: >>> On 04/05/2012 09:14 AM, Hui Zhu wrote: >>> >>>> I post a new version patch according to your comments. >>>> And I have test it with gdb-7.4 and got fail. >>> >>> >>> Thanks. Only a few nits remain, and this is technically ready to >>> check in. See below. >>> >>> However, what's the status of your copyright assignment? Last I >>> heard (and from what I see in FSF's copyright assignment records), we >>> still can't accept changes from you on behalf of Mentor. :-( >> >> What I got is it is OK now. I will send you a mail and cc the people that about the law. > > Hi Pedro, > > The copyright issue is OK now. Yep, took a while, but it's sorted now. Thanks for your patience. > Do you think I can check in this patch? I took another look at the patch, and I now notice you didn't address some of my early comments in : > Please always look at the resulting messages in gdb.sum: .. > There are duplicate messages here. See > . > > I'd lowercase the "First", etc., in the test messages. It's much more common. This is what I get now: >cat testsuite/gdb.sum| grep PASS | sort | uniq -c | sort -nr 2 PASS: gdb.trace/disconnected-tracing.exp: reconnect after unload 2 PASS: gdb.trace/disconnected-tracing.exp: disconnect 1 PASS: gdb.trace/disconnected-tracing.exp: tstart 1 PASS: gdb.trace/disconnected-tracing.exp: trace main 1 PASS: gdb.trace/disconnected-tracing.exp: Third info tracepoints 1 PASS: gdb.trace/disconnected-tracing.exp: set disconnected-tracing on 1 PASS: gdb.trace/disconnected-tracing.exp: set confirm off 1 PASS: gdb.trace/disconnected-tracing.exp: Second info tracepoints 1 PASS: gdb.trace/disconnected-tracing.exp: Fourth info tracepoints 1 PASS: gdb.trace/disconnected-tracing.exp: First info tracepoints Yao also made a valid comment here: that doesn't appear to have been addressed. -- Pedro Alves