From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9298 invoked by alias); 8 May 2012 14:07:48 -0000 Received: (qmail 9259 invoked by uid 22791); 8 May 2012 14:07:46 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 14:07:34 +0000 Received: from iceland.oarcorp.com (192.168.1.171) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.436.0; Tue, 8 May 2012 09:07:33 -0500 Message-ID: <4FA928A5.4060401@oarcorp.com> Date: Tue, 08 May 2012 14:07:00 -0000 From: Joel Sherrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.4) Gecko/20120425 Thunderbird/10.0.4 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: Microblaze simulator - Fix missing prototype References: <4FA82F46.4080901@oarcorp.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00226.txt.bz2 On 05/08/2012 12:21 AM, Sergio Durigan Junior wrote: > Hi Joel, > > Same comment from last e-mail: please send the patches to > gdb-patches@sourceware.org. I am replying this e-mail to the > appropriate list, with comments about your patch, but please send other > patches to that list. > > On Monday, May 07 2012, Joel Sherrill wrote: > >> Without this patch, this generates a missing prototype >> warning which is treated as an error. I don't see this >> routine referenced elsewhere, so there is the possibility >> that it also could be made static. > The `_initialize*' routines are treated specially by the Makefile, when > you build the project. They cannot be made static because they are > called from another source file. Take a look at gdb/Makefile.in, and > search for the rule `init.c:'. I suspected that and figured it was special given the odd name. >> OK to apply? > Small nit below. > >> Index: gdb/microblaze-rom.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/microblaze-rom.c,v >> retrieving revision 1.5 >> diff -u -r1.5 microblaze-rom.c >> --- gdb/microblaze-rom.c 4 Jan 2012 08:17:06 -0000 1.5 >> +++ gdb/microblaze-rom.c 7 May 2012 20:15:54 -0000 >> @@ -25,6 +25,8 @@ >> #include "serial.h" >> #include "regcache.h" >> >> +void _initialize_picobug_rom(void); > There should be a space between the function name and the open paren. OK. I changed that. > > I am not a maintainer, but this change seems pretty trivial to me so > that it can be committed without an explicit approval. I thought so but always feel better getting other opinions. Better to be cautious than reverted. Committed > Thanks, > -- Joel Sherrill, Ph.D. Director of Research& Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985