From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3067 invoked by alias); 8 May 2012 13:57:58 -0000 Received: (qmail 3055 invoked by uid 22791); 8 May 2012 13:57:55 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 13:57:39 +0000 Received: from iceland.oarcorp.com (192.168.1.171) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.436.0; Tue, 8 May 2012 08:57:37 -0500 Message-ID: <4FA92651.3030007@oarcorp.com> Date: Tue, 08 May 2012 13:57:00 -0000 From: Joel Sherrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.4) Gecko/20120425 Thunderbird/10.0.4 MIME-Version: 1.0 To: Mark Kettenis CC: "gdb-patches@sourceware.org" Subject: Re: GDB: Add microblaze-*-rtems* References: <4FA92012.7020905@oarcorp.com> <201205081354.q48DsEIi004621@glazunov.sibelius.xs4all.nl> In-Reply-To: <201205081354.q48DsEIi004621@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00225.txt.bz2 On 05/08/2012 08:54 AM, Mark Kettenis wrote: >> Date: Tue, 8 May 2012 08:30:58 -0500 >> From: Joel Sherrill >> >> OK to apply? >> >> 2012-05-07 Joel Sherrill >> >> * configure.tgt (microblaze*-*-rtems*): New target. > Eh, this diff is pretty much pointless isn't it? It seems that from > GDB's viewpoint, RTEMS is effectively "bare metal". I could live with > changing the comment if you think "running standalone" isn't accurate > enough, but I don't think we should add redundant patterns like this. RTEMS is over 20 years old. In the past, I have seen bare metal targets get changed without someone realizing they were impacting RTEMS. This is as much advertising the target is something to think about when you are hacking as anything else. I am ok with just merging it as a comment though if that's sufficient to ensure that someone hacking here will consider that they are having broader impact than is obvious. > >> Index: gdb/configure.tgt >> =================================================================== >> RCS file: /cvs/src/src/gdb/configure.tgt,v >> retrieving revision 1.253 >> diff -u -r1.253 configure.tgt >> --- gdb/configure.tgt 24 Apr 2012 03:33:16 -0000 1.253 >> +++ gdb/configure.tgt 7 May 2012 20:15:54 -0000 >> @@ -331,8 +331,8 @@ >> monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o" >> gdb_sim=../sim/microblaze/libsim.a >> ;; >> -microblaze*-*-*) >> - # Target: Xilinx MicroBlaze running standalone >> +microblaze*-*-* | microblaze*-*-rtems*) >> + # Target: Xilinx MicroBlaze running standalone (or RTEMS) >> gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o" >> gdb_sim=../sim/microblaze/libsim.a >> ;; -- Joel Sherrill, Ph.D. Director of Research& Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985