From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4823 invoked by alias); 7 May 2012 13:19:18 -0000 Received: (qmail 4811 invoked by uid 22791); 7 May 2012 13:19:16 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 May 2012 13:18:59 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SRNq6-0005ff-Dd from ChungLin_Tang@mentor.com ; Mon, 07 May 2012 06:18:58 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 7 May 2012 06:18:57 -0700 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 7 May 2012 06:18:57 -0700 Message-ID: <4FA7CBC0.6040607@codesourcery.com> Date: Mon, 07 May 2012 13:19:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: , Thomas Schwinge Subject: Re: [PATCH][SH] Signal handler unwinding for SH-Linux References: <4F9CF631.9080807@codesourcery.com> <20120502215148.GC15555@adacore.com> In-Reply-To: <20120502215148.GC15555@adacore.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00174.txt.bz2 On 2012/5/3 05:51 AM, Joel Brobecker wrote: > Overall, this looks good to me. I do not know about SH specifically, > so I will take your word on the specific location and layout of the > sigcontext structure. > > Just a small minor comment: All new functions and globals should > be documented. Usually, when we implement a "virtual method" (a > function destined to be used as a pointer in one of our generic > structures; Eg. sh_linux_sigreturn_init), we do not repeat description. > We just say that this function implements such and such callback > in struct bla bla for such and such situation. The actual documentation > should already be provided at the same location the field itself > is declared. > > For instance, one possible description of sh_linux_sigreturn_init > is: > > /* Implement struct tramp_frame's "init" callback for signal > trampolines on 32-bit SH. */ Hi Joel, thanks for reviewing. I've committed the patch with minor additional comments like you suggested. Chung-Lin